From: Garima Singh <garimasigit@gmail.com>
To: Taylor Blau <me@ttaylorr.com>, stolee@gmail.com
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [RFC PATCH 0/1] commit-graph.c: handle corrupt commit trees
Date: Wed, 4 Sep 2019 14:25:55 -0400 [thread overview]
Message-ID: <c5ba4eaa-f995-5f2e-4f0f-a8f59ba65fd3@gmail.com> (raw)
In-Reply-To: <cover.1567563244.git.me@ttaylorr.com>
On 9/3/2019 10:22 PM, Taylor Blau wrote:
> Hi,
>
> I was running some of the new 'git commit-graph' commands, and noticed
> that I could consistently get 'git commit-graph write --reachable' to
> segfault when a commit's root tree is corrupt.
>
> I have an extremely-unfinished fix attached as an RFC PATCH below, but I
> wanted to get a few thoughts on this before sending it out as a non-RFC.
>
> In my patch, I simply 'die()' when a commit isn't able to be parsed
> (i.e., when 'parse_commit_no_graph' returns a non-zero code), but I
> wanted to see if others thought that this was an OK approach. Some
> thoughts:
I like the idea of completely bailing if the commit can't be parsed too.
Only question: Is there a reason you chose to die() instead of BUG()
like the other two places in that function? What is the criteria of
choosing one over the other?
>
> * It seems like we could write a commit-graph by placing a "filler"
> entry where the broken commit would have gone. I don't see any place
> where this is implemented currently, but this seems like a viable
> alternative to not writing _any_ commits into the commit-graph.
I would rather we didn't do this cause it will probably kick open the
can of always watching for that filler when we are working with the
commit-graph. Or do we already do that today? Maybe @stolee can chime in
on what we do in cases of shallow clones and other potential gaps in the
walk
-Garima
next prev parent reply other threads:[~2019-09-04 18:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 2:22 [RFC PATCH 0/1] commit-graph.c: handle corrupt commit trees Taylor Blau
2019-09-04 2:22 ` [RFC PATCH 1/1] commit-graph.c: die on un-parseable commits Taylor Blau
2019-09-04 3:04 ` Jeff King
2019-09-04 21:18 ` Taylor Blau
2019-09-05 6:47 ` Jeff King
2019-09-06 16:48 ` Derrick Stolee
2019-09-06 17:04 ` Jeff King
2019-09-06 17:19 ` Derrick Stolee
2019-09-06 17:20 ` Derrick Stolee
2019-09-05 22:19 ` Junio C Hamano
2019-09-06 6:35 ` Jeff King
2019-09-06 6:56 ` Jeff King
2019-09-06 16:59 ` Junio C Hamano
2019-09-06 17:04 ` Jeff King
2019-09-09 16:39 ` Junio C Hamano
2019-09-09 16:54 ` Jeff King
2019-09-04 18:25 ` Garima Singh [this message]
2019-09-04 21:21 ` [RFC PATCH 0/1] commit-graph.c: handle corrupt commit trees Taylor Blau
2019-09-05 6:08 ` Jeff King
2019-09-06 16:48 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5ba4eaa-f995-5f2e-4f0f-a8f59ba65fd3@gmail.com \
--to=garimasigit@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).