git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Peter Hunkeler <phunsoft@gmx.net>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
	Git Mailinglist <git@vger.kernel.org>
Subject: Re: Git not commiting anything if file created and "git add"ed in pre-commit hook is the only file in the staging area
Date: Sat, 30 Oct 2021 15:21:14 +0200	[thread overview]
Message-ID: <c5507ba6-6e31-b143-9791-0bcff54acb64@gmx.net> (raw)
In-Reply-To: <dd79e443-3bb9-8b83-746b-7db7c4997ee3@gmx.net>

Pardon my ignorance, but I'm unlear as to how to proceed further with my
issue.
What is the proper process to report a bug, and get a consense whether
it is accepted or rejected?

Regards
Peter

Am 28.10.2021 um 14:08 schrieb Peter Hunkeler:
> Am 28.10.2021 um 00:07 schrieb brian m. carlson:
>> I should point out here that it isn't intended for pre-commit hooks to
>> be used this way; they're intended to verify that the commit meets some
>> standards, not to modify it, although it is of course possible to do.
>>
> I can accept that comment. However:
>
> - wouldn't you agree that git should work consistently? It does not in
> this case. If there is anything to be commited in the index, then the
> "git add" from within the pre-commit hook *is* respected in this commit.
> If there is *nothing* to be commited, except from what was added by the
> pre-commit exit, then it is ignored *for this commit*, but it is added
> and will be commited next time. This is inconsistent behaviour.
>
> - if the decision will be *not* to allow adding from within a pre-commit
> hook, then the "git add" should be rejected. And the documentation
> should say so.
>
> I'll have to understand what all the comments from you and others mean
> (still a git newbee).
>
>> In general, you want to avoid adding automatically generated files to
>> your repository.  That tends to bloat the repository needlessly and is a
>> great way to lead to frequent, hard-to-resolve merge conflicts.
>>
> I'm trying to use git to keep track of changes to my website, which uses
> some framework. The problem is: Some changes modify filesystem entities,
> only, while other changes modify the content of some mysql tables. So I
> need to pack an unload of those tables into the commit. I can do this
> manually (and forget every now and then :-), or I thought the pre-commit
> hook would be a good place to automate this. And, yes, it may well crete
> merge conflicts.
>
> I understand the pre-commit hook is a local thing, and I have to make
> sure the same is active in all repositories. Definitely not something to
> use in a widely shared project.
>
> Thanks a lot
> Peter


  reply	other threads:[~2021-10-30 13:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 19:03 Git not commiting anything if file created and "git add"ed in pre-commit hook is the only file in the staging area Peter Hunkeler
2021-10-27 22:07 ` brian m. carlson
2021-10-27 22:42   ` Jeff King
2021-10-28  1:32     ` Junio C Hamano
2021-10-28 12:08   ` Peter Hunkeler
2021-10-30 13:21     ` Peter Hunkeler [this message]
2021-10-30 16:44       ` Johannes Sixt
2021-10-30 21:25         ` Junio C Hamano
2021-11-02 13:13           ` Peter Hunkeler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5507ba6-6e31-b143-9791-0bcff54acb64@gmx.net \
    --to=phunsoft@gmx.net \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).