From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.4 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 23E3A1F45A for ; Sat, 29 Oct 2022 16:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229682AbiJ2Qgy (ORCPT ); Sat, 29 Oct 2022 12:36:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbiJ2Qgx (ORCPT ); Sat, 29 Oct 2022 12:36:53 -0400 Received: from smtp.hosts.co.uk (smtp.hosts.co.uk [85.233.160.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2D285244A for ; Sat, 29 Oct 2022 09:36:52 -0700 (PDT) Received: from 88-110-102-84.dynamic.dsl.as9105.com ([88.110.102.84] helo=[192.168.1.57]) by smtp.hosts.co.uk with esmtpa (Exim) (envelope-from ) id 1ooopC-0005Pc-A7; Sat, 29 Oct 2022 17:36:46 +0100 Message-ID: Date: Sat, 29 Oct 2022 17:36:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2 3/3] glossary: add reachability bitmap description Content-Language: en-GB To: Derrick Stolee , Junio C Hamano , Abhradeep Chakraborty , Taylor Blau Cc: GitList , Derrick Stolee References: <20221022222539.2333-1-philipoakley@iee.email> <20221022222539.2333-4-philipoakley@iee.email> <746491f4-fb41-92fe-7360-20a845dc21fc@iee.email> From: Philip Oakley In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 25/10/2022 13:34, Derrick Stolee wrote: > On 10/24/2022 5:23 PM, Philip Oakley wrote: >> On 24/10/2022 17:39, Junio C Hamano wrote: >>> Abhradeep Chakraborty writes: >>> >>>> Small correction here - A repository may have multiple bitmaps (one >>>> for each selected commit from the preferred packfile or a >>>> multi-pack-index) but it can have only one ".bitmap" file (as of now). >>>> Bitmaps for the selected commits are stored in that ".bitmap" file. >>>> So I think the below lines (or similar) will work - >>>> >>>> The bitmaps are stored in a ".bitmap" file. A repository may have >>>> at most one ".bitmap" file. The file may belong to either one pack, or the >>>> repository's multi-pack-index (if it exists). >>>> >>>> Feel free to rephrase it accordingly. >>> Sounds good to me. Or Philip's original can be tweaked minimally to >>> say "... may have at most one bitmap file (which stores multiple >>> bitmaps)". >>> >> Thanks both. I'll tweak the description in a day or so to allow Stolee >> to comment if required. > I added my comments about the commit-graph file, and agree with > Abhradeep's suggestions here. > > Adding Taylor as a possible reviewer, too. > > The one thing I will say is that there can be multiple .bitmap > files, but Git will only use one of them. Not sure if that is > worth being pedantic about here, though. > > We'll need to keep this glossary section in mind in case things > change (such as "at most one bitmap file"). > > Thanks, > -Stolee I've gone with the phrase "at most one bitmap file in use." here. The updated series should be sent shortly. Philip.