From: Pratyush Yadav <me@yadavpratyush.com>
To: git <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] git-gui: Perform rescan on window focus-in
Date: Mon, 29 Jul 2019 03:14:42 +0530 [thread overview]
Message-ID: <c3cdbaba-ed57-ce6c-6c07-1e4fe8cc533f@yadavpratyush.com> (raw)
In-Reply-To: <20190728151726.9188-1-me@yadavpratyush.com>
Playing with it for some time, I see some problems with the patch.
Firstly, "bind ." binds that event for the root window and all
subwindows. This means we rescan multiple times on a single FocusIn
event, once for every window. This can be fixed easily with a check for
the root window (aka "."). I'll send a v2 patch with this change.
Secondly, when the context menu is opened via right click, and then
closed, it is recorded as a FocusIn event for our root window, even
though the context menu is a child of the root window. This triggers a
rescan. Unfortunately, I could not find a way to go around this behaviour.
This means some unnecessary rescans, but the rescan looks like a pretty
fast operation even on my slow hard disk, so it should probably not be a
problem.
If someone knows a way around the second issue, please let me know.
On 28/07/19 8:47 PM, Pratyush Yadav wrote:
> If any changes are made to the tree while git-gui is open, the user has
> to manually rescan to see those changes in the gui. With this change, a
> rescan will be performed whenever the window comes in focus, removing
> the need for manual rescans in most cases. A manual rescan will still be
> needed when something makes changes to the tree while git-gui is still
> in focus.
>
> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
> ---
> git-gui/git-gui.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
> index 6de74ce639..8ca2033dc8 100755
> --- a/git-gui/git-gui.sh
> +++ b/git-gui/git-gui.sh
> @@ -3849,6 +3849,7 @@ if {[is_enabled transport]} {
> }
>
> bind . <Key-F5> ui_do_rescan
> +bind . <FocusIn> do_rescan
> bind . <$M1B-Key-r> ui_do_rescan
> bind . <$M1B-Key-R> ui_do_rescan
> bind . <$M1B-Key-s> do_signoff
>
--
Regards,
Pratyush Yadav
prev parent reply other threads:[~2019-07-28 21:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 15:17 [PATCH] git-gui: Perform rescan on window focus-in Pratyush Yadav
2019-07-28 21:36 ` brian m. carlson
2019-07-28 22:10 ` Pratyush Yadav
2019-07-28 22:32 ` Pratyush Yadav
2019-07-28 22:49 ` brian m. carlson
2019-07-29 2:24 ` Mark Levedahl
2019-07-29 2:26 ` Mark Levedahl
2019-07-29 2:28 ` Mark Levedahl
2019-07-29 8:15 ` Pratyush Yadav
2019-07-31 19:42 ` Johannes Schindelin
2019-08-01 21:52 ` Pratyush Yadav
2019-08-02 12:39 ` Johannes Schindelin
2019-08-02 20:00 ` Pratyush Yadav
2019-08-03 20:34 ` Johannes Schindelin
2019-08-04 12:53 ` Pratyush Yadav
2019-08-04 19:10 ` Johannes Schindelin
2019-08-04 20:17 ` Pratyush Yadav
2019-08-02 16:47 ` Junio C Hamano
2019-08-02 20:13 ` Pratyush Yadav
2019-08-04 18:56 ` Johannes Schindelin
2019-07-29 5:09 ` Junio C Hamano
2019-07-29 8:44 ` Pratyush Yadav
2019-07-28 21:44 ` Pratyush Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3cdbaba-ed57-ce6c-6c07-1e4fe8cc533f@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).