From: "René Scharfe" <l.s.r@web.de>
To: Gopal Yadav <gopunop@gmail.com>, git@vger.kernel.org
Cc: Johannes.Schindelin@gmx.de, sunshine@sunshineco.com
Subject: Re: [PATCH] Issue #353: Skipping lazy prereq for skipped tests
Date: Thu, 20 Aug 2020 20:47:35 +0200 [thread overview]
Message-ID: <c3ab29b6-39e8-b0a2-d628-873261850b98@web.de> (raw)
In-Reply-To: <CAAUOv8gf7e=pFGgPBK5cb1_RusWEY7s+iWf95_ETTz_3juzggg@mail.gmail.com>
Am 20.08.20 um 18:01 schrieb Gopal Yadav:
> Skipping lazy prereq for test cases that are skipped via
> the --run option or via GIT_SKIP_TESTS. Issue 353:
> https://github.com/gitgitgadget/git/issues/353
>
> Signed-off-by: Gopal Yadav <gopunop@gmail.com>
> ---
> t/test-lib-functions.sh | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> index 6a8e194a99..bac86ffd9d 100644
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -578,10 +578,10 @@ test_expect_failure () {
> test "$#" = 3 && { test_prereq=$1; shift; } || test_prereq=
> test "$#" = 2 ||
> BUG "not 2 or 3 parameters to test-expect-failure"
> - test_verify_prereq
> - export test_prereq
> if ! test_skip "$@"
> then
> + test_verify_prereq
> + export test_prereq
$test_prereq is used as a named parameter of the function test_skip,
which uses it to determine if a test needs to be skipped due to
missing prerequisites. Checking and exporting its input parameter
only after it succeeded probably won't do any good.
Anyway, didn't e0316695ec3 (test-lib: don't check prereqs of test
cases that won't be run anyway, 2019-11-12) already solve the
issue?
René
prev parent reply other threads:[~2020-08-20 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 16:01 [PATCH] Issue #353: Skipping lazy prereq for skipped tests Gopal Yadav
2020-08-20 18:47 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3ab29b6-39e8-b0a2-d628-873261850b98@web.de \
--to=l.s.r@web.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gopunop@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).