From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_SBL, URIBL_SBL_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id D4A181F4D7 for ; Mon, 13 Jun 2022 21:26:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348713AbiFMV0P (ORCPT ); Mon, 13 Jun 2022 17:26:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351758AbiFMV0C (ORCPT ); Mon, 13 Jun 2022 17:26:02 -0400 Received: from bsmtp5.bon.at (bsmtp5.bon.at [195.3.86.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE9CA12AAE for ; Mon, 13 Jun 2022 14:15:21 -0700 (PDT) Received: from bsmtp3.bon.at (unknown [192.168.181.108]) by bsmtp5.bon.at (Postfix) with ESMTPS id 4LMPVJ20P6z5vFn for ; Mon, 13 Jun 2022 23:15:20 +0200 (CEST) Received: from [192.168.0.98] (unknown [93.83.142.38]) by bsmtp3.bon.at (Postfix) with ESMTPSA id 4LMPVC6Lvnz5tlB; Mon, 13 Jun 2022 23:15:12 +0200 (CEST) Message-ID: Date: Mon, 13 Jun 2022 23:15:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: git filter bug Content-Language: en-US To: Junio C Hamano Cc: "Udoff, Marc" , "Shupak, Vitaly" , "git@vger.kernel.org" References: <101027c97a9b40ce97192b1cee203b07@deshaw.com> <442e3166-4f18-3ee0-e3bc-d24687471d5c@kdbg.org> From: Johannes Sixt In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Am 13.06.22 um 19:29 schrieb Junio C Hamano: > Johannes Sixt writes: > >> git status does not compute differences; it only looks at the stat >> information, and that is by design for performance reasons. So, IMO, >> this is working as designed and not a bug. > > Hmph, is that true? I thought "git status" did an equivalent of > diff.autoRefreshIndex just like other commands like "git diff" at > the Porcelain level. Is it true? I don't know; you tell me ;) git status certainly does autoRefreshIndex, but is that based on a diff computation? I thought git status looks only at stat information. > Is this more like the commonly seen "after you futzed the attributes > to affect normalization, "--renormalize" is needed to force the > index to match the cleaned version of working tree under the new > clean filter rules", I wonder? Not in this case. The modified file that git status reports happens long after git commit -a has already applied the new filter. -- Hannes