From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Udoff, Marc" <Marc.Udoff@deshaw.com>,
"Shupak, Vitaly" <Vitaly.Shupak@deshaw.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git filter bug
Date: Mon, 13 Jun 2022 23:15:12 +0200 [thread overview]
Message-ID: <c2f49b4f-8588-bae1-97cf-91a36b3f16f9@kdbg.org> (raw)
In-Reply-To: <xmqqsfo879r7.fsf@gitster.g>
Am 13.06.22 um 19:29 schrieb Junio C Hamano:
> Johannes Sixt <j6t@kdbg.org> writes:
>
>> git status does not compute differences; it only looks at the stat
>> information, and that is by design for performance reasons. So, IMO,
>> this is working as designed and not a bug.
>
> Hmph, is that true? I thought "git status" did an equivalent of
> diff.autoRefreshIndex just like other commands like "git diff" at
> the Porcelain level.
Is it true? I don't know; you tell me ;) git status certainly does
autoRefreshIndex, but is that based on a diff computation? I thought git
status looks only at stat information.
> Is this more like the commonly seen "after you futzed the attributes
> to affect normalization, "--renormalize" is needed to force the
> index to match the cleaned version of working tree under the new
> clean filter rules", I wonder?
Not in this case. The modified file that git status reports happens long
after git commit -a has already applied the new filter.
-- Hannes
next prev parent reply other threads:[~2022-06-13 21:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 22:19 git filter bug Udoff, Marc
2022-06-11 7:43 ` Johannes Sixt
2022-06-13 17:29 ` Junio C Hamano
2022-06-13 21:15 ` Johannes Sixt [this message]
2022-06-14 19:11 ` Shupak, Vitaly
2022-06-23 12:13 ` Udoff, Marc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2f49b4f-8588-bae1-97cf-91a36b3f16f9@kdbg.org \
--to=j6t@kdbg.org \
--cc=Marc.Udoff@deshaw.com \
--cc=Vitaly.Shupak@deshaw.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).