From: Joe Perches <joe@perches.com>
To: Eric Wong <e@80x24.org>, Emma Brooks <me@pluvano.com>,
Florian Mickler <florian@mickler.org>
Cc: "Jeff King" <peff@peff.net>,
git@vger.kernel.org, "Jakub Narębski" <jnareb@gmail.com>
Subject: Re: [PATCH v2] gitweb: map names/emails with mailmap
Date: Mon, 10 Aug 2020 23:33:55 -0700 [thread overview]
Message-ID: <c2c4f7106f400260ca7ee2ba709fa43c2f0072c9.camel@perches.com> (raw)
In-Reply-To: <20200811061729.GA7134@dcvr>
On Tue, 2020-08-11 at 06:17 +0000, Eric Wong wrote:
> Emma Brooks <me@pluvano.com> wrote:
> > On 2020-08-10 06:02:49-0400, Jeff King wrote:
> > > There was a little discussion in response to v1 on whether we could
> > > reuse the existing C mailmap code:
> > >
> > > https://lore.kernel.org/git/20200731010129.GD240563@coredump.intra.peff.net/
> > >
> > > Did you have any thoughts on that?
> >
> > I think it's probably not worth the effort to make the necessary changes
> > to "rev-list --header" Junio mentioned, just for gitweb.
> >
> > I agree it's a bit worrisome to have a second parser that could
> > potentially behave slightly differently than the main implementation.
>
> +Cc Joe Perches
>
> Fwiw, there's already a GPL-2.0 Perl .mailmap parser in
> scripts/get_maintainer.pl of the Linux kernel which Joe
> maintains:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/get_maintainer.pl
+cc Florian Mickler
Might be different behavior, dunno.
Florian Mickler wrote most of that and I
believe I rewrote it a bit, mostly for style.
If the perl code is useful to you, do what
you will with it, I give you my permission.
I don't believe get_maintainer needs to be
changed unless it's shown to be different
than what git does already. I think it's
the same output.
> Been thinking about adding mailmap support to public-inbox in
> the send-email reply instructions, too. (but public-inbox is
> AGPL-3+, so I can't steal the code w/o permission)
>
> > What if we added tests for gitweb's mailmap parsing based on the same
> > cases used for Git itself?
>
> That's probably fine IMHO; especially if it's just for gitweb display
> (and not writing anything that's meant to be stored forever).
>
> There's already dozens of different parsers for email addresses,
> MIME, mailbox formats, etc. all with slightly different edge cases;
> things still mostly work well enough to not be a huge problem.
> (Same goes for Markdown, HTML, formats and even JSON :x)
prev parent reply other threads:[~2020-08-11 6:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 4:12 [RFC PATCH] gitweb: Map names/emails with mailmap Emma Brooks
2020-07-30 16:20 ` Junio C Hamano
2020-07-31 1:01 ` Jeff King
2020-07-31 2:10 ` Junio C Hamano
2020-08-08 21:34 ` [PATCH] " Emma Brooks
2020-08-09 23:04 ` [PATCH v2] gitweb: map " Emma Brooks
2020-08-10 0:49 ` Eric Sunshine
2020-08-10 3:12 ` Emma Brooks
2020-08-10 5:41 ` Eric Sunshine
2020-08-10 10:02 ` Jeff King
2020-08-11 4:17 ` Emma Brooks
2020-08-11 4:48 ` Eric Sunshine
2020-08-11 4:55 ` Jeff King
2020-09-05 2:55 ` Emma Brooks
2020-09-05 3:26 ` Junio C Hamano
2020-09-07 22:10 ` Emma Brooks
2020-08-11 6:17 ` Eric Wong
2020-08-11 6:33 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2c4f7106f400260ca7ee2ba709fa43c2f0072c9.camel@perches.com \
--to=joe@perches.com \
--cc=e@80x24.org \
--cc=florian@mickler.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=me@pluvano.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).