git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Elijah Newren <newren@gmail.com>, Elijah Newren <newren@gmail.com>
Subject: [PATCH 11/12] treewide: add direct includes currently only pulled in transitively
Date: Sun, 03 Dec 2023 06:41:20 +0000	[thread overview]
Message-ID: <c11b94bfc7c084d03ed46a24b81ec1dfa9c51c69.1701585683.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1617.git.1701585682.gitgitgadget@gmail.com>

From: Elijah Newren <newren@gmail.com>

The next commit will remove a bunch of unnecessary includes, but to do
so, we need some of the lower level direct includes that files rely on
to be explicitly specified.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 builtin/commit-graph.c      | 1 +
 builtin/for-each-ref.c      | 1 +
 builtin/fsmonitor--daemon.c | 1 +
 commit-graph.c              | 1 +
 4 files changed, 4 insertions(+)

diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
index c5684342ecf..81a28c6fcdd 100644
--- a/builtin/commit-graph.c
+++ b/builtin/commit-graph.c
@@ -11,6 +11,7 @@
 #include "object-store-ll.h"
 #include "progress.h"
 #include "replace-object.h"
+#include "strbuf.h"
 #include "tag.h"
 #include "trace2.h"
 
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index 6235d72f9d3..b5bc700d13c 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -1,4 +1,5 @@
 #include "builtin.h"
+#include "commit.h"
 #include "config.h"
 #include "gettext.h"
 #include "object.h"
diff --git a/builtin/fsmonitor--daemon.c b/builtin/fsmonitor--daemon.c
index 7260604534f..9f80b9eaff5 100644
--- a/builtin/fsmonitor--daemon.c
+++ b/builtin/fsmonitor--daemon.c
@@ -12,6 +12,7 @@
 #include "compat/fsmonitor/fsm-health.h"
 #include "compat/fsmonitor/fsm-listen.h"
 #include "fsmonitor--daemon.h"
+#include "repository.h"
 #include "simple-ipc.h"
 #include "khash.h"
 #include "pkt-line.h"
diff --git a/commit-graph.c b/commit-graph.c
index 5bfee53e87b..e7212400da3 100644
--- a/commit-graph.c
+++ b/commit-graph.c
@@ -1,5 +1,6 @@
 #include "git-compat-util.h"
 #include "config.h"
+#include "csum-file.h"
 #include "gettext.h"
 #include "hex.h"
 #include "lockfile.h"
-- 
gitgitgadget



  parent reply	other threads:[~2023-12-03  6:42 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-03  6:41 [PATCH 00/12] Additional header cleanups (removing unnecessary includes) Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 01/12] treewide: remove unnecessary includes from header files Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 02/12] treewide: remove unnecessary includes in source files Elijah Newren via GitGitGadget
2023-12-03 13:15   ` Junio C Hamano
2023-12-20 19:34     ` Junio C Hamano
2023-12-20 20:42       ` Elijah Newren
2023-12-03  6:41 ` [PATCH 03/12] archive.h: remove unnecessary include Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 04/12] blame.h: remove unnecessary includes Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 05/12] fsmonitor--daemon.h: " Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 06/12] http.h: remove unnecessary include Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 07/12] line-log.h: " Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 08/12] pkt-line.h: " Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 09/12] submodule-config.h: " Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 10/12] trace2/tr2_tls.h: " Elijah Newren via GitGitGadget
2023-12-03  6:41 ` Elijah Newren via GitGitGadget [this message]
2023-12-03  6:41 ` [PATCH 12/12] treewide: remove unnecessary includes in source files Elijah Newren via GitGitGadget
2023-12-23 17:14 ` [PATCH v2 00/12] Additional header cleanups (removing unnecessary includes) Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 01/12] treewide: remove unnecessary includes from header files Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 02/12] treewide: remove unnecessary includes in source files Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 03/12] archive.h: remove unnecessary include Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 04/12] blame.h: remove unnecessary includes Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 05/12] fsmonitor--daemon.h: " Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 06/12] http.h: remove unnecessary include Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 07/12] line-log.h: " Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 08/12] pkt-line.h: " Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 09/12] submodule-config.h: " Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 10/12] trace2/tr2_tls.h: " Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 11/12] treewide: add direct includes currently only pulled in transitively Elijah Newren via GitGitGadget
2023-12-23 17:15   ` [PATCH v2 12/12] treewide: remove unnecessary includes in source files Elijah Newren via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c11b94bfc7c084d03ed46a24b81ec1dfa9c51c69.1701585683.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).