git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philip Oakley <philipoakley@iee.org>
To: Anthony Sottile <asottile@umich.edu>,
	git@vger.kernel.org, Philip Oakley <philipoakley@iee.org>
Subject: Re: [PATCH] doc: improve grammar in git-update-index
Date: Sat, 15 Dec 2018 17:06:54 +0000	[thread overview]
Message-ID: <bfe22381-864a-4a6b-8dd9-78e268e52c36@iee.org> (raw)
In-Reply-To: <20181214212504.3164-1-asottile@umich.edu>

On 14/12/2018 21:25, Anthony Sottile wrote:
> Signed-off-by: Anthony Sottile <asottile@umich.edu>
> ---
>   Documentation/git-update-index.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt
> index 1c4d146a4..9c03ca167 100644
> --- a/Documentation/git-update-index.txt
> +++ b/Documentation/git-update-index.txt
> @@ -326,7 +326,7 @@ inefficient `lstat(2)`.  If your filesystem is one of them, you
>   can set "assume unchanged" bit to paths you have not changed to
>   cause Git not to do this check.  Note that setting this bit on a
>   path does not mean Git will check the contents of the file to
> -see if it has changed -- it makes Git to omit any checking and
> +see if it has changed -- it means Git will skip any checking and
>   assume it has *not* changed.  When you make changes to working
>   tree files, you have to explicitly tell Git about it by dropping
>   "assume unchanged" bit, either before or after you modify them.

Doesn't this also need the caveat that it is _a promise by the user_ 
that they will not change the file, such that Git doesn't need to keep 
checking, and that occasionally Git will check, or may perform 
unexpected actions if the user has the wrong mental model.

-- 

Philip



  reply	other threads:[~2018-12-15 17:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 21:25 [PATCH] doc: improve grammar in git-update-index Anthony Sottile
2018-12-15 17:06 ` Philip Oakley [this message]
2018-12-16  0:21   ` Anthony Sottile
2018-12-26 18:12   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfe22381-864a-4a6b-8dd9-78e268e52c36@iee.org \
    --to=philipoakley@iee.org \
    --cc=asottile@umich.edu \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).