From: Sebastian Schuberth <sschuberth@gmail.com>
To: Stefan Beller <sbeller@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Fwd: Failed shallow submodule clone for fixed SHA1 falls back to checking out HEAD
Date: Tue, 18 Apr 2017 21:18:23 +0200 [thread overview]
Message-ID: <bf1bd6e4-e099-53b6-428a-85d1e02ee75c@gmail.com> (raw)
In-Reply-To: <CAGZ79kZy1rBUaF1XbUOPUxDPzT1FwCp92jbbiO4RX3aiCoNkxQ@mail.gmail.com>
On 2017-04-18 21:12, Stefan Beller wrote:
>> Wouldn't it make more sense to unshallow the submodule clone in this case and checkout the configured commit 2aa4cce7d7fd46164030f2b4d244c4b89e77f722 afterwards?
>
> If I remember correctly the conclusion of the discussion at the time
> was that people are more interested in "less data" rather than
> "correct data" because otherwise you would not have asked for shallow.
I do believe this is an awkward choice. What does it help to get less
data if it's the wrong data?
--
Sebastian Schuberth
prev parent reply other threads:[~2017-04-18 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 13:04 Failed shallow submodule clone for fixed SHA1 falls back to checking out HEAD Sebastian Schuberth
[not found] ` <CAGZ79kazh5+6vx87PVXUNgyJebO2m6pEkT1G8rSFvCmWQZdSuw@mail.gmail.com>
2017-04-18 19:12 ` Fwd: " Stefan Beller
2017-04-18 19:18 ` Sebastian Schuberth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf1bd6e4-e099-53b6-428a-85d1e02ee75c@gmail.com \
--to=sschuberth@gmail.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).