* http: a non-curl_multi interface?
@ 2009-03-02 13:14 Tay Ray Chuan
2009-03-02 13:26 ` Daniel Stenberg
0 siblings, 1 reply; 3+ messages in thread
From: Tay Ray Chuan @ 2009-03-02 13:14 UTC (permalink / raw
To: git
HI,
there's been several complaints about how git uses curl, particularly
how it forces one to use curl's multi interface, so I've tried my hand
at implementing a curl interface that doesn't need curl_multi.
This would allow git to work without curl_multi.
The non-curl_multi set of functions are done, and I've also taught
push and http-push --persistent, to force git to behave as though
USE_CURL_MULTI isn't defined.
Do you guys think this would bring any benefits, apart from requiring
the user to use a curl library with the multi interface? Based on what
I read in the docs, this would mean less open/closed connections,
minimized credential prompting (if authentication is required), more
backward compatibility, but it would also mean a possible performance
degradation in git, since all http requests are sequential.
--
Cheers,
Ray Chuan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: http: a non-curl_multi interface?
2009-03-02 13:14 http: a non-curl_multi interface? Tay Ray Chuan
@ 2009-03-02 13:26 ` Daniel Stenberg
2009-03-03 11:19 ` Tay Ray Chuan
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Stenberg @ 2009-03-02 13:26 UTC (permalink / raw
To: Tay Ray Chuan; +Cc: git
On Mon, 2 Mar 2009, Tay Ray Chuan wrote:
I'm replying on this topic as a libcurl guy, I don't know much of git
internals.
> Do you guys think this would bring any benefits, apart from requiring
> the user to use a curl library with the multi interface?
You mean NOT requiring then I guess.
What I don't quite grasp (and I must admit I have not followed the critique on
this matter) is why using the multi interface of libcurl is a problem to
anyone as all libcurl versions in modern times features it. And if you have a
libcurl with it working badly, you have a too old libcurl anyway and should
rather upgrade...
> Based on what I read in the docs, this would mean less open/closed
> connections,
I don't see how that is true. In fact, properly used I would claim that an
application using the multi interface would in general use less connections
and do more connection re-use than otherwise. But of course it depends on a
lot of factors.
Again, this requires a reasonably recent libcurl (since 7.16.0 - october 2006
- libcurl keeps the "connection cache" in the multi handle instead of in each
individual easy handle.)
> minimized credential prompting (if authentication is required), more
> backward compatibility, but it would also mean a possible performance
> degradation in git, since all http requests are sequential.
I figure you can test that fairly easy now when you have a patch pending for
this change and the existing code base is using the multi interface
approach...
--
/ daniel.haxx.se
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: http: a non-curl_multi interface?
2009-03-02 13:26 ` Daniel Stenberg
@ 2009-03-03 11:19 ` Tay Ray Chuan
0 siblings, 0 replies; 3+ messages in thread
From: Tay Ray Chuan @ 2009-03-03 11:19 UTC (permalink / raw
To: Daniel Stenberg; +Cc: git
Hi,
On Mon, Mar 2, 2009 at 9:26 PM, Daniel Stenberg <daniel@haxx.se> wrote:
> What I don't quite grasp (and I must admit I have not followed the critique
> on this matter) is why using the multi interface of libcurl is a problem to
> anyone as all libcurl versions in modern times features it. And if you have
> a libcurl with it working badly, you have a too old libcurl anyway and
> should rather upgrade...
>
> ...
>
> I don't see how that is true. In fact, properly used I would claim that an
> application using the multi interface would in general use less connections
> and do more connection re-use than otherwise. But of course it depends on a
> lot of factors.
Hmm, there aren't any very obvious benefits are there?
In that case, I guess, an re-organization of the http api/curl usage
would be more useful to git.
--
Cheers,
Ray Chuan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-03 11:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-02 13:14 http: a non-curl_multi interface? Tay Ray Chuan
2009-03-02 13:26 ` Daniel Stenberg
2009-03-03 11:19 ` Tay Ray Chuan
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).