mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ben Avison <>
To: "Ævar Arnfjörð Bjarmason" <>
Subject: Re: [PATCH] clone: add `--remote-submodules` flag
Date: Tue, 14 May 2019 19:38:58 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 13/05/2019 22:12, Ævar Arnfjörð Bjarmason wrote:
> On Mon, May 13 2019, Ben Avison wrote:
>> +		if (option_remote_submodules == 1) {
> I see you copied this from code above the context, but to check a bool
> variable just use "if (var)" not "if (var == 1)".

OK. Would you prefer I edit the line above it as well? I simply assumed 
that was the way it was preferred to perform the test for some reason.

>> +test_expect_success 'check the default is --no-remote-submodules' '
>> +	test_when_finished "rm -rf super_clone" &&
>> +	git clone --recurse-submodules --no-remote-submodules "file://$pwd/." super_clone &&
> This isn't testing the default, it just tests --no-remote-submodules,
> i.e. if you change the "static int" assignment to "1" (to make this new
> option the default) all these tests will still pass.

That was a cut-and-paste error - I meant to omit both new options as you 
suggest! Good spot.


  reply	other threads:[~2019-05-14 18:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 17:59 [PATCH] clone: add `--remote-submodules` flag Ben Avison
2019-05-13 21:12 ` Ævar Arnfjörð Bjarmason
2019-05-14 18:38   ` Ben Avison [this message]
2019-05-19 14:26   ` [PATCH v2] " Ben Avison
2019-05-16 11:31 ` [PATCH] " Duy Nguyen
2019-05-16 17:50   ` Ben Avison
2019-05-18 11:40     ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).