From: Sebastian Schuberth <sschuberth@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] submodule: remove a superfluous second check for the "new" variable
Date: Mon, 17 Apr 2017 20:21:23 +0200 [thread overview]
Message-ID: <be511659-83fb-9b34-0ce8-8f6c21b91143@gmail.com> (raw)
In-Reply-To: <CAGZ79kb01g0AoD0b+ysqd-H049BAX-j0om2pwPqXA7fXhX2Y8w@mail.gmail.com>
On 2017-04-17 20:02, Stefan Beller wrote:
>> diff --git a/submodule.c b/submodule.c
>> index c52d663..68623bd 100644
>> --- a/submodule.c
>> +++ b/submodule.c
>> @@ -1396,8 +1396,7 @@ int submodule_move_head(const char *path,
>> cp1.no_stdin = 1;
>> cp1.dir = path;
>>
>> - argv_array_pushl(&cp1.args, "update-ref", "HEAD",
>> - new ? new : EMPTY_TREE_SHA1_HEX, NULL);
>> + argv_array_pushl(&cp1.args, "update-ref", "HEAD", new, NULL);
>
> EMPTY_TREE_SHA1_HEX != NULL?
>
> Can you clarify the intent in the commit message?
Sure. A few lines up (3 lines out of the diff) we have "if (new) {" [1], thus there's no need to check "new != NULL" here again.
[1] https://github.com/git/git/pull/345/files#diff-471db3ea6697763218bb8335a95ece57R1392
--
Sebastian Schuberth
prev parent reply other threads:[~2017-04-17 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 7:59 [PATCH] submodule: remove a superfluous second check for the "new" variable Sebastian Schuberth
2017-04-17 18:02 ` Stefan Beller
2017-04-17 18:21 ` Sebastian Schuberth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be511659-83fb-9b34-0ce8-8f6c21b91143@gmail.com \
--to=sschuberth@gmail.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).