From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,FSL_HAS_TINYURL, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id DBEE31F4B4 for ; Sun, 10 Jan 2021 22:25:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726479AbhAJWYD (ORCPT ); Sun, 10 Jan 2021 17:24:03 -0500 Received: from mail-gateway-shared11.cyon.net ([194.126.200.64]:45208 "EHLO mail-gateway-shared11.cyon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726418AbhAJWYD (ORCPT ); Sun, 10 Jan 2021 17:24:03 -0500 Received: from s019.cyon.net ([149.126.4.28]) by mail-gateway-shared11.cyon.net with esmtpsa (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim) (envelope-from ) id 1kyj7G-0002dj-2r for git@vger.kernel.org; Sun, 10 Jan 2021 23:23:20 +0100 Received: from [10.20.10.232] (port=62366 helo=mail.cyon.ch) by s019.cyon.net with esmtpa (Exim 4.93) (envelope-from ) id 1kyj7E-00Bheo-Tm; Sun, 10 Jan 2021 23:23:16 +0100 Subject: Re: [PATCH] gitk: check main window visibility before waiting for it to show To: Tobias Pietzsch via GitGitGadget , git@vger.kernel.org Cc: Paul Mackerras , Tobias Pietzsch , Tobias Pietzsch References: From: Beat Bolli Message-ID: Date: Sun, 10 Jan 2021 23:23:15 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: de-CH Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - s019.cyon.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - drbeat.li X-Get-Message-Sender-Via: s019.cyon.net: authenticated_id: ig@drbeat.li X-Authenticated-Sender: s019.cyon.net: ig@drbeat.li X-OutGoing-Spam-Status: No, score=-1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 10.01.21 00:26, Tobias Pietzsch via GitGitGadget wrote: > From: Tobias Pietzsch > > If the main window is already visible when gitk waits for it to > become visible, gitk hangs forever. > This commit adds a check whether the window is already visible. > See https://wiki.tcl-lang.org/page/tkwait+visibility > > Signed-off-by: Tobias Pietzsch > --- > gitk: check main window visibility before waiting for it to show > > If the main window is already visible when gitk waits for it to become > visible, gitk hangs forever. > > This commit adds a check whether the window is already visible. See > https://wiki.tcl-lang.org/page/tkwait+visibility > > The symptom of the for-ever waiting is that gitk shows just an empty > window, like this: https://tinyurl.com/yxr5qlf6 It happens (to me) on > macOS 11.1 with git-gui installed via homebrew. It doesn't happen on > macOS 10.14. Thanks, this also occurred on my macOS 10.14.6 just an hour ago after a recent brew upgrade, and the patch makes gitk usable again. Cheers, Beat