git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Sverre Rabbelier" <alturin@gmail.com>
To: "Lea Wiemann" <lewiemann@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"John Hawley" <warthog19@eaglescrag.net>
Subject: Re: Development strategy
Date: Tue, 3 Jun 2008 01:04:01 +0200	[thread overview]
Message-ID: <bd6139dc0806021604w1a066229idb788a9b918ee24b@mail.gmail.com> (raw)
In-Reply-To: <484475FC.8020804@gmail.com>

On Tue, Jun 3, 2008 at 12:36 AM, Lea Wiemann <lewiemann@gmail.com> wrote:
> Are you suggesting that the squashed patches get merged, or that the
> squashed patches get reviewed but the finer-granulated patches get merged?

The latter is what I suggested :). I reckon you'll want ot keep the
finger-granulated history for future reference / bisecting, but when
reviewing that seems overkill.

>  In the former case, I'd probably prefer to work with larger patches in the
> first place (and not just squash them on the review branch), since they are
> easier to handle -- e.g. I sometimes need to go back and change things in
> earlier commits, and in those cases larger commits are easier.

If you don't think you're omitting information you will want later on
(meaning the more specific commit history), by all means, go with the
bigger patches. I find it nicer to create small commits, with the plus
that it cuts down the size of the commit msg too ;).

-- 
Cheers,

Sverre Rabbelier

  reply	other threads:[~2008-06-02 23:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02 15:51 Development strategy Lea Wiemann
2008-06-02 18:30 ` Sverre Rabbelier
2008-06-02 19:09   ` Jakub Narebski
2008-06-02 19:24     ` Sverre Rabbelier
2008-06-02 19:24     ` Johannes Schindelin
2008-06-02 19:39     ` Stephan Beyer
2008-06-02 20:02       ` Johannes Schindelin
2008-06-02 22:36   ` Lea Wiemann
2008-06-02 23:04     ` Sverre Rabbelier [this message]
2008-06-02 23:35 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd6139dc0806021604w1a066229idb788a9b918ee24b@mail.gmail.com \
    --to=alturin@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=lewiemann@gmail.com \
    --cc=sverre@rabbelier.nl \
    --cc=warthog19@eaglescrag.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).