From: "Daniel Richard G." <skunk@iSKUNK.ORG>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Minor portability issues + fixes
Date: Tue, 19 May 2020 00:26:02 -0400 [thread overview]
Message-ID: <bbaacb8f-e2d3-4c4a-98d7-acea0b637081@www.fastmail.com> (raw)
In-Reply-To: <20200519030440.GB20332@Carlos-MBP>
Hi Carlo,
On Mon, 2020 May 18 23:04-04:00, Carlo Marcelo Arenas Belón wrote:
> On Mon, May 18, 2020 at 09:15:58PM -0400, Daniel Richard G. wrote:
> >
> > I am building Git 2.26.2 on AIX. A few compilation errors arose, but
> > they are resolvable with a few minor changes that will improve overall
> > portability.
>
> which version of AIX is this?
4.3, believe it or not :-] This system is used for compatibility
testing of a legacy product.
> we include inttypes.h which is supposed to include stdint.h per POSIX[1]
>
> could you take a look at that header and see if there is some macro definition
> preventing that to happen?
There's no #include at all, and stdint.h is not present under
/usr/include/. But I am building with GCC 4.7 (as the original
vendor compiler has outlived its usefulness), and that provides a
modern stdint.h.
The original inttypes.h is fixincluded by GCC, but this did not add the
stdint.h #include.
As I remarked to Jeff, would it be kosher to #include both inttypes.h
and stdint.h if both are present? It seems that most of the time, the
latter would be a no-op.
--Daniel
--
Daniel Richard G. || skunk@iSKUNK.ORG
My ASCII-art .sig got a bad case of Times New Roman.
prev parent reply other threads:[~2020-05-19 4:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 1:15 Minor portability issues + fixes Daniel Richard G.
2020-05-19 2:49 ` Jeff King
2020-05-19 4:22 ` Daniel Richard G.
2020-05-20 4:28 ` Jeff King
2020-05-21 4:29 ` Daniel Richard G.
2020-05-22 20:03 ` Jeff King
2020-05-19 3:04 ` Carlo Marcelo Arenas Belón
2020-05-19 4:26 ` Daniel Richard G. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbaacb8f-e2d3-4c4a-98d7-acea0b637081@www.fastmail.com \
--to=skunk@iskunk.org \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).