From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Derrick Stolee <stolee@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: What's cooking in git.git (Apr 2018, #01; Mon, 9)
Date: Mon, 9 Apr 2018 17:49:35 +0100 [thread overview]
Message-ID: <bba6e3ba-ab28-8cda-eab3-91ec3591bcb5@ramsayjones.plus.com> (raw)
In-Reply-To: <98394864-ece6-5112-0274-b2399087f207@gmail.com>
On 09/04/18 14:37, Derrick Stolee wrote:
> On 4/9/2018 6:21 AM, Junio C Hamano wrote:
>> * ds/commit-graph (2018-04-02) 16 commits
>> - commit-graph: implement "--additive" option
>> - commit-graph: build graph from starting commits
>> - commit-graph: read only from specific pack-indexes
>> - commit: integrate commit graph with commit parsing
>> - commit-graph: close under reachability
>> - commit-graph: add core.commitGraph setting
>> - commit-graph: implement git commit-graph read
>> - commit-graph: implement git-commit-graph write
>> - commit-graph: implement write_commit_graph()
>> - commit-graph: create git-commit-graph builtin
>> - graph: add commit graph design document
>> - commit-graph: add format document
>> - csum-file: refactor finalize_hashfile() method
>> - csum-file: rename hashclose() to finalize_hashfile()
>> - Merge branch 'jk/cached-commit-buffer' into HEAD
>> - Merge branch 'jt/binsearch-with-fanout' into HEAD
>> (this branch is used by ds/lazy-load-trees.)
>>
>> Precompute and store information necessary for ancestry traversal
>> in a separate file to optimize graph walking.
>>
>> Ready???
>> It seems that this topic is getting there.
>
> I think this patch is ready to go, barring the edit of "--additive" to "--append" in the final commit message and squashing following diff into "commit-graph: implement git commit-graph read":
>
> @@ -31,7 +31,7 @@ static struct opts_commit_graph {
>
> static int graph_read(int argc, const char **argv)
> {
> - struct commit_graph *graph = 0;
> + struct commit_graph *graph = NULL;
> char *graph_name;
>
> static struct option builtin_commit_graph_read_options[] = {
>
Also, it seems that the 'static' keyword has been dropped from the
declaration of 'commit_graph' (commit-graph.c #183) again:
$ diff nsp-out psp-out
18a19
> SP chdir-notify.c
23a25,26
> SP commit-graph.c
> commit-graph.c:183:21: warning: symbol 'commit_graph' was not declared. Should it be static?
66a70
> SP json-writer.c
209a214,215
> SP builtin/commit-graph.c
> builtin/commit-graph.c:34:38: warning: Using plain integer as NULL pointer
299d304
< fast-import.c:303:40: warning: Using plain integer as NULL pointer
312a318
> SP t/helper/test-json-writer.c
315a322
> SP t/helper/test-print-larger-than-ssize.c
$
ATB,
Ramsay Jones
next prev parent reply other threads:[~2018-04-09 16:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 10:21 What's cooking in git.git (Apr 2018, #01; Mon, 9) Junio C Hamano
2018-04-09 13:37 ` Derrick Stolee
2018-04-09 16:49 ` Ramsay Jones [this message]
2018-04-09 22:08 ` Junio C Hamano
2018-04-10 12:57 ` Derrick Stolee
2018-04-10 19:12 ` Stefan Beller
2018-04-10 19:21 ` Ramsay Jones
2018-04-10 19:21 ` Ramsay Jones
2018-04-10 19:35 ` Derrick Stolee
2018-04-10 20:22 ` Ramsay Jones
2018-04-10 20:37 ` Ramsay Jones
2018-04-10 21:46 ` Junio C Hamano
2018-04-09 15:31 ` Duy Nguyen
2018-04-09 17:23 ` Stefan Beller
2018-04-09 20:14 ` Johannes Schindelin
2018-04-09 21:32 ` Johannes Schindelin
2018-04-10 12:25 ` Johannes Schindelin
2018-04-10 21:02 ` git-gui branches, was " Johannes Schindelin
2018-04-10 21:38 ` Junio C Hamano
2018-04-10 21:54 ` Stefan Beller
2018-04-10 22:41 ` Johannes Schindelin
2018-04-11 10:13 ` Phillip Wood
2018-04-11 18:47 ` Jakub Narebski
2018-04-11 20:51 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bba6e3ba-ab28-8cda-eab3-91ec3591bcb5@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).