From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Shourya Shukla <shouryashukla.oo@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
christian.couder@gmail.com, gitster@pobox.com,
liu.denton@gmail.com, git@vger.kernel.org, congdanhqx@gmail.com
Subject: Re: [PATCH v2] submodule: port subcommand 'set-branch' from shell to C
Date: Wed, 20 May 2020 18:42:48 +0530 [thread overview]
Message-ID: <b96324d4-04bd-8f64-e334-d3613dc3be6f@gmail.com> (raw)
In-Reply-To: <20200520121530.GA7992@konoha>
Hi Shourya,
On 20-05-2020 17:45, Shourya Shukla wrote:
> On 19/05 02:57, Eric Sunshine wrote:
>> On Tue, May 19, 2020 at 2:27 PM Shourya Shukla
>> <shouryashukla.oo@gmail.com> wrote:
>>> + if (opt_branch && opt_default)
>>> + die(_("--branch and --default do not make sense together"));
>>
>> A more precise way to say this is:
>>
>> die(_("--branch and --default are mutually exclusive"));
>
> Will that be clear to everyone? What I mean is maybe a person from a
> non-mathematical background (someone doing programming as a hobby maybe)
> will not grasp at this at one go and will have to search it's meaning
> online. Isn't it fine as-is?
>
While "mutually exclusive" might be prominently used in mathematics. I
don't think it is only understandable by people with a mathematical
background.
Moreover, I see 183 results in 36 files for "mutually exclusive" in
git.git (including translation files). So, this isn't anything new.
I agree with Eric's suggestion. It makes the error message concise which
is a nice side benefit.
--
Sivaraam
next prev parent reply other threads:[~2020-05-20 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 18:26 [PATCH v2] submodule: port subcommand 'set-branch' from shell to C Shourya Shukla
2020-05-19 18:57 ` Eric Sunshine
2020-05-20 12:15 ` Shourya Shukla
2020-05-20 13:12 ` Kaartic Sivaraam [this message]
2020-05-20 14:37 ` Junio C Hamano
2020-05-20 14:45 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b96324d4-04bd-8f64-e334-d3613dc3be6f@gmail.com \
--to=kaartic.sivaraam@gmail.com \
--cc=christian.couder@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=shouryashukla.oo@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).