From: Philip Oakley <philipoakley@iee.email>
To: Junio C Hamano <gitster@pobox.com>
Cc: Philip Oakley via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 4/4] doc add: renormalize is not idempotent for CRCRLF
Date: Sun, 10 Jul 2022 23:25:32 +0100 [thread overview]
Message-ID: <b9094655-2116-547f-15cb-0a4cce07a960@iee.email> (raw)
In-Reply-To: <xmqqsfn8pqts.fsf@gitster.g>
On 10/07/2022 23:04, Junio C Hamano wrote:
> Philip Oakley <philipoakley@iee.email> writes:
>
>>>> + This option implies `-u`. Lone CR characters are untouched, so
>>>> + cleaning *^* not idempotent. A CRCRLF sequence cleans to CRLF.
>>> Lack of verb BE somewhere.
>> '^' It took me three re-reads to see my mistyping as my head knew what
>> I'd meant to write, I've marked above as a note to self.
>> Aside: Are there any guides / suggestions / how-to's for on-line
>> reviewing that you can recommend o
> Sorry, but I do not know of any good "trick" to fight against our
> common tendency to easily miss trivial typoes and thinkos in what we
> ourselves wrote. We can be surprisingly blind to what a colleague
> can spot immediately, and that is why it helps to have a thorough
> read-through by a reviewer with fresh eyes. When I was a more
> prolific contributor, I sometimes tried to read aloud what I wrote
> to myself, both docs and code, and caught silly mistakes before
> sending them out to the list, but I do not recommend it to others.
Thanks. There does appear to be a lack of literature or articles in this
area of on-list reviewing
I've not even seen an list of snippets collated from email advice.
Other than the email etiquette's starter for ten on don't top post ;-)
--
Philip
next prev parent reply other threads:[~2022-07-10 22:27 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 16:56 [PATCH 0/4] Add some Glossary terms, and extra renormalize information Philip Oakley via GitGitGadget
2022-07-09 16:56 ` [PATCH 1/4] glossary: add Object DataBase (ODB) abbreviation Philip Oakley via GitGitGadget
2022-07-09 16:56 ` [PATCH 2/4] glossary: add commit graph description Philip Oakley via GitGitGadget
2022-07-09 21:20 ` Junio C Hamano
2022-07-10 21:37 ` Philip Oakley
2022-08-30 14:33 ` Philip Oakley
2022-07-09 16:56 ` [PATCH 3/4] glossary: add reachability bitmap description Philip Oakley via GitGitGadget
2022-07-09 16:56 ` [PATCH 4/4] doc add: renormalize is not idempotent for CRCRLF Philip Oakley via GitGitGadget
2022-07-09 21:06 ` Junio C Hamano
2022-07-10 21:52 ` Philip Oakley
2022-07-10 22:04 ` Junio C Hamano
2022-07-10 22:25 ` Philip Oakley [this message]
2022-07-10 7:48 ` Torsten Bögershausen
2022-07-10 22:09 ` Philip Oakley
2022-08-05 22:26 ` Junio C Hamano
2022-08-06 19:22 ` Torsten Bögershausen
2022-08-08 14:32 ` Philip Oakley
2022-08-08 16:21 ` Junio C Hamano
2022-08-09 18:44 ` Torsten Bögershausen
2022-08-10 14:44 ` [PATCH v2 0/1] .. Add extra renormalize information Philip Oakley
2022-08-10 14:44 ` [PATCH v2 1/1] doc add: renormalize is not idempotent for CRCRLF Philip Oakley
2022-08-10 17:11 ` Torsten Bögershausen
2022-08-10 17:42 ` Junio C Hamano
2022-07-09 21:34 ` [PATCH 0/4] Add some Glossary terms, and extra renormalize information Junio C Hamano
2022-07-10 15:20 ` Philip Oakley
2022-10-22 22:25 ` [PATCH v2 0/3] Add some Glossary of terms information Philip Oakley
2022-10-22 22:25 ` [PATCH v2 1/3] doc: use 'object database' not ODB or abbreviation Philip Oakley
2022-10-22 22:25 ` [PATCH v2 2/3] glossary: add "commit graph" description Philip Oakley
2022-10-25 12:31 ` Derrick Stolee
2022-10-29 16:32 ` Philip Oakley
2022-10-22 22:25 ` [PATCH v2 3/3] glossary: add reachability bitmap description Philip Oakley
2022-10-24 7:43 ` Abhradeep Chakraborty
2022-10-24 16:39 ` Junio C Hamano
2022-10-24 21:23 ` Philip Oakley
2022-10-25 12:34 ` Derrick Stolee
2022-10-25 15:53 ` Junio C Hamano
2022-10-29 16:36 ` Philip Oakley
2022-10-23 1:49 ` [PATCH v2 0/3] Add some Glossary of terms information Junio C Hamano
2022-10-29 16:41 ` [PATCH v3 0/4] " Philip Oakley
2022-10-29 16:41 ` [PATCH v3 1/4] doc: use 'object database' not ODB or abbreviation Philip Oakley
2022-10-29 16:41 ` [PATCH v3 2/4] glossary: add "commit graph" description Philip Oakley
2022-10-29 16:41 ` [PATCH v3 3/4] glossary: add reachability bitmap description Philip Oakley
2022-10-29 16:41 ` [PATCH v3 4/4] doc: use "commit-graph" hyphenation consistently Philip Oakley
2022-10-29 17:24 ` [PATCH v3 0/4] Add some Glossary of terms information Taylor Blau
2022-10-29 17:34 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9094655-2116-547f-15cb-0a4cce07a960@iee.email \
--to=philipoakley@iee.email \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).