git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "André Goddard Rosa" <andre.goddard@gmail.com>
To: "Petr Baudis" <pasky@suse.cz>
Cc: "Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [RFC variant 2 of 2] "needs update" considered harmful
Date: Sun, 20 Jul 2008 11:03:04 -0300	[thread overview]
Message-ID: <b8bf37780807200703we8f8608yb009c1039b829b23@mail.gmail.com> (raw)
In-Reply-To: <20080720112957.GE32184@machine.or.cz>

On Sun, Jul 20, 2008 at 8:29 AM, Petr Baudis <pasky@suse.cz> wrote:
> On Sun, Jul 20, 2008 at 12:48:21AM -0700, Junio C Hamano wrote:
>> "git update-index --refresh", "git reset" and "git add --refresh" have
>> reported paths that have local modifications as "needs update" since the
>> beginning of git.
>>
>> Although this is logically correct in that you need to update the index at
>> that path before you can commit that change, it is now becoming more and
>> more clear, especially with the continuous push for user friendliness
>> since 1.5.0 series, that the message is suboptimal.  After all, the change
>> may be something the user might want to get rid of, and "updating" would
>> be absolutely a wrong thing to do if that is the case.
>>
>> I prepared two alternatives to solve this.  Both aim to reword the message
>> to more neutral "locally modified".
>>
>> This patch is a more straightforward variant that changes the message not
>> only for Porcelain commands ("add" and "reset") but also changes the
>> output from the plumbing command "update-index".
>>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>
> I believe this is a good thing. Scripts need to be modified for the

Thanks for doing that. I hope this goes mainline soon.

-- 
[]s,
André Goddard

      parent reply	other threads:[~2008-07-20 14:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-20  6:31 [PATCH] refresh-index: fix bitmask assignment Junio C Hamano
2008-07-20  7:03 ` Junio C Hamano
2008-07-20  7:28   ` Junio C Hamano
2008-07-20  7:48     ` [RFC] "needs update" considered harmful Junio C Hamano
2008-07-21 18:17       ` Jay Soffian
2008-07-20  7:48 ` [RFC variant 1 of 2] " Junio C Hamano
2008-07-20  7:48 ` [RFC variant 2 " Junio C Hamano
2008-07-20 11:29   ` Petr Baudis
2008-07-20 12:41     ` Johannes Schindelin
2008-07-20 19:29       ` Junio C Hamano
2008-07-21 17:27         ` Jay Soffian
2008-07-20 14:03     ` André Goddard Rosa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8bf37780807200703we8f8608yb009c1039b829b23@mail.gmail.com \
    --to=andre.goddard@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).