git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Tim Dufala <contact@timdufala.com>
To: git@vger.kernel.org
Subject: git bash completion modifies COMP_WORDBREAKS breaking other autocompletion
Date: Mon, 23 May 2022 19:45:19 -0700	[thread overview]
Message-ID: <b89da76a-465c-9398-bf3d-3b091d74de89@timdufala.com> (raw)

Thank you for filling out a Git bug report!
Please answer the following questions to help us understand your issue.

What did you do before the bug happened? (Steps to reproduce your issue)
I used bash autocompletion. So:
git <tab>

What did you expect to happen? (Expected behavior)
The bash environment variable ${COMP_WORDBREAKS} remains unmodified.

What happened instead? (Actual behavior)
COMP_WORDBREAKS is modified. Specifically, a colon is appended.

What's different between what you expected and what actually happened?
COMP_WORDBREAKS being modified.

Anything else you want to add:
This breaks auto-completion of programs that rely on completing 
arguments that
include colons. For example, autocompleting arguments like: "file://abc" 
- hitting
tab gives something like "file:file://abc". As far as I'm aware, modifying
COMP_WORDBREAKS is no longer considered good practice.

Doing some research, I see the following patch, which I'd be in favor of 
using:
https://patchwork.kernel.org/project/git/patch/20201104174716.783348-6-felipe.contreras@gmail.com/

Not sure if this will just get lost in the noise, but I figured I'd send 
this at least as a 'bump' towards this issue.

[System Info]
git version:
git version 2.36.1
cpu: x86_64
no commit associated with this build
sizeof-long: 8
sizeof-size_t: 8
shell-path: /bin/sh
uname: Linux 5.13.0-41-generic #46~20.04.1-Ubuntu SMP Wed Apr 20 
13:16:21 UTC 2022 x86_64
compiler info: gnuc: 9.4
libc info: glibc: 2.31
$SHELL (typically, interactive shell): /bin/bash


[Enabled Hooks]
not run from a git repository - no hooks to show


                 reply	other threads:[~2022-05-24  2:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b89da76a-465c-9398-bf3d-3b091d74de89@timdufala.com \
    --to=contact@timdufala.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).