mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "" <>
To: "Ævar Arnfjörð Bjarmason" <>
Cc: git <>,
	"Derrick Stolee" <>,
	"Junio C Hamano" <>
Subject: Re: Re: [PATCH] builtin/gc: warn when core.commitGraph is disabled
Date: Thu, 13 May 2021 16:17:54 +0800	[thread overview]
Message-ID: <> (raw)

>On Mon, May 10 2021, wrote:
>> From: Li Linchao <>
>> Throw warning message when core.commitGraph is disabled in commit-graph
>> maintenance task.
>Won't this cause the gc.log issue noted in
>More importantly, I don't think this UX makes sense. We said we didn't
>want it, so why warn about it?
>Maybe there are good reasons to, but this commit message / patch doesn't
>make the case for it...
Uh, well, maybe I should argue for this patch a bit more.

First this is in git maintenance task, I've read the link you post, and I feel it has nothing to do with maintenance task.

Second I hope the `commit-graph` task can do the same thing with `incremental repack` task that to warn user when the related necessary setting is not yet ready, instead of running quietly, but doing nothing.


  reply	other threads:[~2021-05-13  8:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10  9:43 [PATCH] builtin/gc: warn when core.commitGraph is disabled lilinchao
2021-05-10 11:55 ` Ævar Arnfjörð Bjarmason
2021-05-13  8:17   ` lilinchao [this message]
2021-05-13 11:24     ` Ævar Arnfjörð Bjarmason
2021-05-10 18:12 ` Junio C Hamano
     [not found] ` <>
2021-05-11  2:17   ` lilinchao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).