From: Phillip Wood <phillip.wood123@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Phillip Wood via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH 1/1] t3420: remove progress lines before comparing output
Date: Thu, 4 Jul 2019 10:53:40 +0100 [thread overview]
Message-ID: <b7cdf6af-061f-6578-384f-e378b712eea6@gmail.com> (raw)
In-Reply-To: <xmqqmuhw4afu.fsf@gitster-ct.c.googlers.com>
On 02/07/2019 18:23, Junio C Hamano wrote:
> Phillip Wood <phillip.wood123@gmail.com> writes:
>
>>> As long as sed implementation used here does not do anything funny
>>> to CR, I think the approach to strip everything before the last CR
>>> on the line is sensible. As I am not familiar with how Windows port
>>> of sed wants to treat a CR byte in the pattern, I am not sure about
>>> the precondition of the above statement, though.
>>
>> I wondered about that too, but it passes the CI tests under windows.
>
> Hopefully Git for Windows, MinGW, and CygWin would all behave
> similarly.
>
>>> I also have to wonder if we can/want to do this without an extra
>>> printf process every time we sanitize the output, though I do not
>>> think I care too deeply about it.
>>
>> I could add 're="$(printf ...)"' to the setup at the top of the file
>> if you want
>
> As I do not care too deeply about it, we recently saw a lot about
> reducing number of processes in the tests, so apparently some folks
> care and I presume they want to see something like that to happen.
> I do not think $re is a good name for such a variable, though ;-)
Yes, $re was just a place holder - naming is hard ...
Best Wishes
Phillip
next prev parent reply other threads:[~2019-07-04 9:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 13:11 [PATCH 0/1] t3420 remove progress from output Phillip Wood via GitGitGadget
2019-07-01 13:11 ` [PATCH 1/1] t3420: remove progress lines before comparing output Phillip Wood via GitGitGadget
2019-07-01 21:01 ` Junio C Hamano
2019-07-02 15:54 ` Phillip Wood
2019-07-02 17:23 ` Junio C Hamano
2019-07-04 9:53 ` Phillip Wood [this message]
2019-07-04 9:47 ` [PATCH v2 0/1] t3420 remove progress from output Phillip Wood via GitGitGadget
2019-07-04 9:47 ` [PATCH v2 1/1] t3420: remove progress lines before comparing output Phillip Wood via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7cdf6af-061f-6578-384f-e378b712eea6@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).