git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Pratyush Yadav <me@yadavpratyush.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] git-gui: Call do_quit before destroying the main window
Date: Tue, 6 Aug 2019 21:22:38 +0530	[thread overview]
Message-ID: <b7cbe50d-879f-68b9-30b2-181c3058297f@yadavpratyush.com> (raw)
In-Reply-To: <20190804143919.10732-1-me@yadavpratyush.com>

If there are no comments/objections with this patch, can it be merged 
please?

On 8/4/19 8:09 PM, Pratyush Yadav wrote:
> If the toplevel window for the window being destroyed is the main window
> (aka "."), then simply destroying it means the cleanup tasks are not
> executed like saving the commit message buffer, saving window state,
> etc. All this is handled by do_quit so, call it instead of directly
> destroying the main window. For other toplevel windows, the old behavior
> remains.
> 
> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
> ---
>   git-gui/git-gui.sh | 19 +++++++++++++++++--
>   1 file changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
> index 6de74ce639..6ec562d5da 100755
> --- a/git-gui/git-gui.sh
> +++ b/git-gui/git-gui.sh
> @@ -3030,8 +3030,23 @@ unset doc_path doc_url
>   wm protocol . WM_DELETE_WINDOW do_quit
>   bind all <$M1B-Key-q> do_quit
>   bind all <$M1B-Key-Q> do_quit
> -bind all <$M1B-Key-w> {destroy [winfo toplevel %W]}
> -bind all <$M1B-Key-W> {destroy [winfo toplevel %W]}
> +
> +set m1b_w_script {
> +	set toplvl_win [winfo toplevel %W]
> +
> +	# If we are destroying the main window, we should call do_quit to take
> +	# care of cleanup before exiting the program.
> +	if {$toplvl_win eq "."} {
> +		do_quit
> +	} else {
> +		destroy $toplvl_win
> +	}
> +}
> +
> +bind all <$M1B-Key-w> $m1b_w_script
> +bind all <$M1B-Key-W> $m1b_w_script
> +
> +unset m1b_w_script
>   
>   set subcommand_args {}
>   proc usage {} {
> 


-- 
Regards,
Pratyush Yadav

  reply	other threads:[~2019-08-06 15:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-04 14:39 Pratyush Yadav
2019-08-06 15:52 ` Pratyush Yadav [this message]
2019-08-06 18:22   ` Junio C Hamano
2019-08-06 19:04     ` Pratyush Yadav
2019-08-07  5:21       ` Junio C Hamano
2019-08-07 17:41         ` Junio C Hamano
2019-08-07 17:50       ` Junio C Hamano
2019-08-07 21:03         ` Pratyush Yadav
2019-08-07 21:53           ` Junio C Hamano
2019-08-09 14:42             ` Pratyush Yadav
2019-08-09 20:03               ` Junio C Hamano
2019-08-13 13:40                 ` Pratyush Yadav
2019-08-13 17:30                   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7cbe50d-879f-68b9-30b2-181c3058297f@yadavpratyush.com \
    --to=me@yadavpratyush.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --subject='Re: [PATCH] git-gui: Call do_quit before destroying the main window' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).