From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 98C6E1F9FE for ; Thu, 22 Jul 2021 17:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229845AbhGVQUi (ORCPT ); Thu, 22 Jul 2021 12:20:38 -0400 Received: from siwi.pair.com ([209.68.5.199]:16363 "EHLO siwi.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234575AbhGVQTX (ORCPT ); Thu, 22 Jul 2021 12:19:23 -0400 Received: from siwi.pair.com (localhost [127.0.0.1]) by siwi.pair.com (Postfix) with ESMTP id 1B5C93F410A; Thu, 22 Jul 2021 12:59:56 -0400 (EDT) Received: from SME-RED-HCI8.sme.test.net (162-238-212-202.lightspeed.rlghnc.sbcglobal.net [162.238.212.202]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by siwi.pair.com (Postfix) with ESMTPSA id C67583F4103; Thu, 22 Jul 2021 12:59:55 -0400 (EDT) Subject: Re: [PATCH v6 0/2] tr2: log parent process name To: Emily Shaffer , git@vger.kernel.org Cc: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , Junio C Hamano , Bagas Sanjaya , "Randall S. Becker" , Jonathan Nieder References: <20210722012707.205776-1-emilyshaffer@google.com> From: Jeff Hostetler Message-ID: Date: Thu, 22 Jul 2021 12:59:54 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20210722012707.205776-1-emilyshaffer@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 7/21/21 9:27 PM, Emily Shaffer wrote: > Since v5, I reshuffled some of the platform-specific compilation recipe > around per Jeff H's comments on v5. I think these are at odds with > Ævar's comments, though, so I guess let's take a look and see how > strongly we feel? :) > > Otherwise I also made the logic inversion Junio suggested to make the > logic easier to follow in procinfo.c:trace2_collect_process_info. > > Thanks, > - Emily ... LGTM Thanks, Jeff