From: Denton Liu <liu.denton@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: [PATCH v2] t0000: cover GIT_SKIP_TESTS blindspots
Date: Tue, 8 Oct 2019 02:22:47 -0700 [thread overview]
Message-ID: <b5f3af8a630aec2d8bffe8e76f1d113171eda250.1570526491.git.liu.denton@gmail.com> (raw)
In-Reply-To: <08273a0d0deae610b93d7f5eb28b0df5f978bf20.1569996425.git.liu.denton@gmail.com>
Currently, the tests for GIT_SKIP_TESTS do not cover the situation where
we skip an entire test suite. The tests also do not cover the situation
where we have GIT_SKIP_TESTS defined but the test suite does not match.
Add two test cases so we cover this blindspot.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
Changes since v1:
* Added another test case to cover the blindspot where GIT_SKIP_TESTS is
defined but the test suite does not match.
Range-diff against v1:
1: 08273a0d0d ! 1: b5f3af8a63 t0000: cover GIT_SKIP_TESTS blindspot
@@ Metadata
Author: Denton Liu <liu.denton@gmail.com>
## Commit message ##
- t0000: cover GIT_SKIP_TESTS blindspot
+ t0000: cover GIT_SKIP_TESTS blindspots
Currently, the tests for GIT_SKIP_TESTS do not cover the situation where
- we skip an entire test suite. Add a test case so we cover this
- blindspot.
+ we skip an entire test suite. The tests also do not cover the situation
+ where we have GIT_SKIP_TESTS defined but the test suite does not match.
+
+ Add two test cases so we cover this blindspot.
## t/t0000-basic.sh ##
@@ t/t0000-basic.sh: test_expect_success 'GIT_SKIP_TESTS sh pattern' "
@@ t/t0000-basic.sh: test_expect_success 'GIT_SKIP_TESTS sh pattern' "
+ EOF
+ )
+"
++
++test_expect_success 'GIT_SKIP_TESTS does not skip unmatched suite' "
++ (
++ GIT_SKIP_TESTS='notgit' && export GIT_SKIP_TESTS &&
++ run_sub_test_lib_test git-skip-tests-unmatched-suite \
++ 'GIT_SKIP_TESTS does not skip unmatched suite' <<-\\EOF &&
++ for i in 1 2 3
++ do
++ test_expect_success \"passing test #\$i\" 'true'
++ done
++ test_done
++ EOF
++ check_sub_test_lib_test git-skip-tests-unmatched-suite <<-\\EOF
++ > ok 1 - passing test #1
++ > ok 2 - passing test #2
++ > ok 3 - passing test #3
++ > # passed all 3 test(s)
++ > 1..3
++ EOF
++ )
++"
+
test_expect_success '--run basic' "
run_sub_test_lib_test run-basic \
t/t0000-basic.sh | 38 ++++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 4c01f60dd3..4d3f7ba295 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -391,6 +391,44 @@ test_expect_success 'GIT_SKIP_TESTS sh pattern' "
)
"
+test_expect_success 'GIT_SKIP_TESTS entire suite' "
+ (
+ GIT_SKIP_TESTS='git' && export GIT_SKIP_TESTS &&
+ run_sub_test_lib_test git-skip-tests-entire-suite \
+ 'GIT_SKIP_TESTS entire suite' <<-\\EOF &&
+ for i in 1 2 3
+ do
+ test_expect_success \"passing test #\$i\" 'true'
+ done
+ test_done
+ EOF
+ check_sub_test_lib_test git-skip-tests-entire-suite <<-\\EOF
+ > 1..0 # SKIP skip all tests in git
+ EOF
+ )
+"
+
+test_expect_success 'GIT_SKIP_TESTS does not skip unmatched suite' "
+ (
+ GIT_SKIP_TESTS='notgit' && export GIT_SKIP_TESTS &&
+ run_sub_test_lib_test git-skip-tests-unmatched-suite \
+ 'GIT_SKIP_TESTS does not skip unmatched suite' <<-\\EOF &&
+ for i in 1 2 3
+ do
+ test_expect_success \"passing test #\$i\" 'true'
+ done
+ test_done
+ EOF
+ check_sub_test_lib_test git-skip-tests-unmatched-suite <<-\\EOF
+ > ok 1 - passing test #1
+ > ok 2 - passing test #2
+ > ok 3 - passing test #3
+ > # passed all 3 test(s)
+ > 1..3
+ EOF
+ )
+"
+
test_expect_success '--run basic' "
run_sub_test_lib_test run-basic \
'--run basic' --run='1 3 5' <<-\\EOF &&
--
2.23.0.248.g3a9dd8fb08
prev parent reply other threads:[~2019-10-08 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 6:14 [PATCH] t0000: cover GIT_SKIP_TESTS blindspot Denton Liu
2019-10-08 9:22 ` Denton Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5f3af8a630aec2d8bffe8e76f1d113171eda250.1570526491.git.liu.denton@gmail.com \
--to=liu.denton@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).