From: Paolo Bonzini <pbonzini@redhat.com>
To: "René Scharfe" <l.s.r@web.de>,
"Junio C Hamano" <gitster@pobox.com>,
"Maxime Louet" <maxime@saumon.io>
Cc: git@vger.kernel.org
Subject: Re: Verbose commit message diff not showing changes from pre-commit hook
Date: Mon, 27 Jul 2020 20:13:54 +0200 [thread overview]
Message-ID: <b5f1769d-5c60-bca4-3f46-e55962fa1805@redhat.com> (raw)
In-Reply-To: <a8c19b13-3f8c-6602-24dd-ef58af70d702@web.de>
On 26/07/20 19:41, René Scharfe wrote:
>>
>> However, ec84bd00 moved the place where we re-read the on-disk index
>> in the sequence, and updated a message that used to read:
>>
>> - /*
>> - * Re-read the index as pre-commit hook could have updated it,
>> - * and write it out as a tree.
>> - */
>>
>> to:
>>
>> + /*
>> + * Re-read the index as pre-commit hook could have updated it,
>> + * and write it out as a tree. We must do this before we invoke
>> + * the editor and after we invoke run_status above.
>> + */
> When I read "refactor" in the title, I assume that the patch in
> question doesn't change user-visible behavior.
That was probably the intention.
>> Unfortunately there is no mention of the reason why we "must" here.
> @Paolo: Do you perhaps remember the reason?
I think the idea was to use run_status for the "commitable" assignment.
Paolo
prev parent reply other threads:[~2020-07-27 18:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 14:47 Verbose commit message diff not showing changes from pre-commit hook Maxime Louet
2020-07-25 15:00 ` Junio C Hamano
2020-07-25 15:31 ` Junio C Hamano
2020-07-26 17:41 ` René Scharfe
2020-07-26 19:45 ` Maxime Louet
2020-07-27 18:13 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5f1769d-5c60-bca4-3f46-e55962fa1805@redhat.com \
--to=pbonzini@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=maxime@saumon.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).