From: "René Scharfe" <l.s.r@web.de>
To: Ramkumar Ramachandra <r@artagnon.com>,
Christian Couder <christian.couder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>, "Miriam R." <mirucam@gmail.com>
Subject: Re: git bisect bad @
Date: Tue, 18 Jan 2022 13:45:24 +0100 [thread overview]
Message-ID: <b5c85f32-eaea-a5f9-c648-5bdbe1c5cd62@web.de> (raw)
In-Reply-To: <e90803fb-00a1-4575-9a8b-8f7fed7f5e6a@www.fastmail.com>
Am 14.01.22 um 09:04 schrieb Ramkumar Ramachandra:
> René Scharfe wrote:
>> Using the shell allows the bisect run command to be any shell command,
>> not just some script. E.g. you could bisect a build failure with just
>> "git bisect run make". Quite useful.
>
> Ah, that's quite useful, yes. The problem of improving user
> experience with bisect is getting more and more hairy. May I suggest
> something tractable, albeit not too elegant, and certainly not
> perfect, in view of improving user experience in common use cases?
I like the pragmatism.
> 1. If argv[0] of the supplied command is found in $PATH, check it for
> executable permissions. Otherwise, error out. It's highly unlikely
> that the user meant a shell builtin, which would supersede the
> executable in $PATH.
Installing something in $PATH and forgetting to make it executable
sounds like a very rare case. And if we find such a thing, would it
warrant erroring out? What if there is an executable version somewhere
else in the $PATH or a shell builtin or an alias?
> 2. If argv[0] is found in the current directory, prompt for "Did you
> mean ... [Y/n]?"
That is more likely, I imagine, but is the existence of such a file
strong enough a signal to interrupt the program? I think we are
better off making sure there actually is a problem first.
> 3. If checking on merge-base fails, improve the error message with
> "Perhaps your bisect script is broken?" and reset bisect
> automatically.
That would have no effect if the bad commit is a straight descendant of
the good one. And a merge base being bad can have other causes than a
missing script.
René
next prev parent reply other threads:[~2022-01-18 12:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 19:29 git bisect bad @ Ramkumar Ramachandra
2022-01-09 19:54 ` Junio C Hamano
2022-01-09 20:48 ` Ramkumar Ramachandra
2022-01-10 9:01 ` [PATCH] bisect: report actual bisect_state() argument on error René Scharfe
2022-01-10 10:04 ` Ramkumar Ramachandra
2022-01-10 17:06 ` git bisect bad @ Junio C Hamano
2022-01-10 21:04 ` Ramkumar Ramachandra
2022-01-12 9:04 ` René Scharfe
2022-01-12 17:50 ` Junio C Hamano
2022-01-12 18:34 ` René Scharfe
2022-01-13 5:10 ` René Scharfe
2022-01-13 9:32 ` Ramkumar Ramachandra
2022-01-13 12:28 ` Christian Couder
2022-01-13 13:55 ` René Scharfe
2022-01-13 15:16 ` Ramkumar Ramachandra
2022-01-14 7:47 ` René Scharfe
2022-01-14 8:04 ` Ramkumar Ramachandra
2022-01-18 12:45 ` René Scharfe [this message]
2022-01-14 18:42 ` Junio C Hamano
2022-01-13 18:40 ` Junio C Hamano
2022-01-18 12:45 ` [PATCH v2 1/4] bisect--helper: report actual bisect_state() argument on error René Scharfe
2022-01-18 12:46 ` [PATCH v2 2/4] bisect--helper: release strbuf and strvec on run error René Scharfe
2022-01-18 12:46 ` [PATCH v2 3/4] bisect: document run behavior with exit codes 126 and 127 René Scharfe
2022-01-18 12:46 ` [PATCH v2 4/4] bisect--helper: double-check run command on exit code " René Scharfe
2022-01-19 2:36 ` Junio C Hamano
2022-01-19 7:52 ` René Scharfe
2022-02-04 0:42 ` Junio C Hamano
2022-02-04 17:16 ` René Scharfe
2022-02-04 18:16 ` Ramkumar Ramachandra
2022-02-04 19:32 ` Junio C Hamano
2022-02-04 18:09 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5c85f32-eaea-a5f9-c648-5bdbe1c5cd62@web.de \
--to=l.s.r@web.de \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mirucam@gmail.com \
--cc=r@artagnon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).