From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 143581F8C6 for ; Tue, 10 Aug 2021 13:41:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238181AbhHJNlf (ORCPT ); Tue, 10 Aug 2021 09:41:35 -0400 Received: from siwi.pair.com ([209.68.5.199]:53104 "EHLO siwi.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238028AbhHJNlb (ORCPT ); Tue, 10 Aug 2021 09:41:31 -0400 Received: from siwi.pair.com (localhost [127.0.0.1]) by siwi.pair.com (Postfix) with ESMTP id DC8063F40F5; Tue, 10 Aug 2021 09:41:08 -0400 (EDT) Received: from DC-2021.bjwce.com (162-238-212-202.lightspeed.rlghnc.sbcglobal.net [162.238.212.202]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by siwi.pair.com (Postfix) with ESMTPSA id 9ECE43F4098; Tue, 10 Aug 2021 09:41:08 -0400 (EDT) Subject: Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic To: Junio C Hamano Cc: =?UTF-8?Q?Carlo_Marcelo_Arenas_Bel=c3=b3n?= , git@vger.kernel.org, jeffhost@microsoft.com References: <20210809063004.73736-1-carenas@gmail.com> <42dce285-9599-4c7c-d351-44c1e338337e@jeffhostetler.com> From: Jeff Hostetler Message-ID: Date: Tue, 10 Aug 2021 09:41:07 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 8/9/21 12:49 PM, Junio C Hamano wrote: > Jeff Hostetler writes: > >> On 8/9/21 2:30 AM, Carlo Marcelo Arenas Belón wrote: >>> seen with both clang 12 and gcc 11 in seen (including jh/builtin-fsmonitor) >>> as of a5a42b9f76 (from Jul 1) >>> it should be squashed into the corresponding patch from the series >>> as shown >>> in the subject and reroll IMHO; notice Junio also has some bandaid sparse >>> fixes for t/helper/test-touch.c that should be included. >>> a similar additional fix for C89 compatibility to be send as a reply >>> later >>> Carlo Marcelo Arenas Belón (2): >>> fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon >>> fixup! fsmonitor--daemon: implement handle_client callback >>> builtin/fsmonitor--daemon.c | 2 +- >>> fsmonitor-ipc.h | 2 ++ >>> 2 files changed, 3 insertions(+), 1 deletion(-) >>> >> >> Thanks! > > Thanks, both. > > Jeff, I understand that this is planned to be rerolled post release, > so I'll not touch these fixups and let yuou worry about them ;-) > Right. I'll include them with my next version. Jeff