From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 123F01F9FC for ; Wed, 12 Jan 2022 18:36:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356315AbiALSfR (ORCPT ); Wed, 12 Jan 2022 13:35:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356295AbiALSfO (ORCPT ); Wed, 12 Jan 2022 13:35:14 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBADAC06173F for ; Wed, 12 Jan 2022 10:35:13 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id n30-20020a17090a5aa100b001b2b6509685so6555226pji.3 for ; Wed, 12 Jan 2022 10:35:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=MHo36GDD40bbjKCa4KBl3OCWlz6Ps7xa+rx1AFe/dec=; b=KjEbK7jfhopAP/mUMzdabCljttGADTESJUOqxIRucxjUfxT9Bdw6LILJrsDfMCpe3r w4Z4niRRbLT6OyvMBvsD1IB2LW/0HykO+SeFGaaWkLWT5ZFsHC8/nOImJi8mMRm//KnJ U7bQW12q622wWxHEa07MsaHIDZf30ebWXzoNYuP+3V1pMtXMH/smmwPz+mQMO/wVsDXh 1M9GInFuFHFvmeu8H/tEV/UMtRTh8i8NH9+npvaL+YGO7TpRblj1WRJEW0gkkNMDV9ZR KISm4sKT5lGkDVVki6/MLw/gkWkCouDS6zef4723SUnG1Zba/UQRPDbmv3tGO3xmLWUg t1rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=MHo36GDD40bbjKCa4KBl3OCWlz6Ps7xa+rx1AFe/dec=; b=avS1l2cYfQqBoyDlVel/6aQogtBQaP/aouYeJuKwd1lT1ngCO68afqrMFeNlnprQsD NVsvtJhygeYeGBQc0OjxVQ0nNnhadE4j9RnG0INrDnptsc6PCQtENJ4+p53ZmRHUqRx2 W3D/e7nWKnFKS2bsN05GFfPXuPAZGb4Eto3HbhVfKhbumewNUj5wZnBd913f5B58ETPd PBGGIgIMkWVZaZw6EXgQkiWxCgJv6oMNcxXhcpf8h4Y/oaaFHUSZSEH4wXpIQf4G3hcd /6FJBGuUPys6lHRc+8pdK1HeTal+hIuzoybnfIWA3+1ZZHdXyMjGfG1ZxB+rpeHCcxb8 OYDg== X-Gm-Message-State: AOAM533dRkJguuqrgQeGVZmXju5OWpMf25JYnHqJiBrl3YOhfFFREkoA HBj7mbIn28zJyxKrviapwZU= X-Google-Smtp-Source: ABdhPJyUhEdLA+KHD0NvrEyYiLYhA9uR/0xVN/DlMS/qRyPQzHl9LLhzqSVI/ZQyWXd7J/bUMiAVxw== X-Received: by 2002:aa7:96bd:0:b0:4c1:232c:818a with SMTP id g29-20020aa796bd000000b004c1232c818amr806813pfk.35.1642012513422; Wed, 12 Jan 2022 10:35:13 -0800 (PST) Received: from ?IPV6:2601:602:9e81:12c0:b8d6:f480:77a5:ee68? ([2601:602:9e81:12c0:b8d6:f480:77a5:ee68]) by smtp.gmail.com with ESMTPSA id om7sm374543pjb.47.2022.01.12.10.35.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 10:35:13 -0800 (PST) Message-ID: Date: Wed, 12 Jan 2022 10:35:12 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 0/3] sparse checkout: custom bash completion updates Content-Language: en-US To: Taylor Blau Cc: Elijah Newren , Lessley Dennington via GitGitGadget , Git Mailing List , Derrick Stolee , Junio C Hamano , johannes.schindelin@gmail.com, Denton Liu References: <92913af3-7985-0789-eee0-c84601d2a31f@gmail.com> From: Lessley Dennington In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 1/11/22 1:45 PM, Taylor Blau wrote: > On Tue, Jan 11, 2022 at 09:17:38AM -0800, Lessley Dennington wrote: >> On 1/10/22 2:38 PM, Elijah Newren wrote: >>> Other than that one nit, patches 1-2 (and the testcases in patch 3) are: >>> >>> Reviewed-by: Elijah Newren >>> >>> Since I wrote the new __gitcomp() function in patch 3, it might be >>> nice if we can find another reviewer for it. Especially since I've >>> only lightly touched the completion code and there might be better >>> ways of achieving what I wrote there. >> >> I agree - I'll chat with some folks today to try to find the best person >> to take a look. > > Having another set of eyes on this code never hurts, but looking through > this file's shortlog (especially with `--since=1.year.ago`), I'm not > sure how many active reviewers in this area we still have. > > Perhaps the best thing to do would be to grow some new area experts here > instead. If I were in Lessley's shoes, I would "think aloud" to make > sure I agreed with your implementation for the new `__gitcomp()` > function. > > If other reviewers happen to be around (perhaps Denton, who I added to > the CC) that doesn't hurt either, but short of that... > > > Thanks, > Taylor Thanks for the help here, Taylor! I like this suggestion and will add my thoughts to Elijah's __gitcomp_directories function.