git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH] git-gui: Make usettk off by default on Mac OS X
@ 2020-10-13 19:02 Stefan Haller
  2020-10-13 19:08 ` Stefan Haller
  2020-10-14 10:01 ` Pratyush Yadav
  0 siblings, 2 replies; 4+ messages in thread
From: Stefan Haller @ 2020-10-13 19:02 UTC (permalink / raw)
  To: git; +Cc: me

This option is supposed to make a Tcl/Tk app look more like a native app
for the respective platform. This doesn't seem to work on Mac, it looks
worse than the non-ttk appearance (for instance, the colored pane
headers are grey).

Users who really prefer the ttk look can still turn it on with the
gui.usettk config.

Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
---
 git-gui.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-gui.sh b/git-gui.sh
index 867b8ce..f7e13ca 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -897,7 +897,7 @@ set default_config(gui.fontui) [font configure font_ui]
 set default_config(gui.fontdiff) [font configure font_diff]
 # TODO: this option should be added to the git-config documentation
 set default_config(gui.maxfilesdisplayed) 5000
-set default_config(gui.usettk) 1
+set default_config(gui.usettk) [expr ![is_MacOSX]]
 set default_config(gui.warndetachedcommit) 1
 set default_config(gui.tabsize) 8
 set font_descs {
-- 
2.29.0.rc1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] git-gui: Make usettk off by default on Mac OS X
  2020-10-13 19:02 [PATCH] git-gui: Make usettk off by default on Mac OS X Stefan Haller
@ 2020-10-13 19:08 ` Stefan Haller
  2020-10-14 10:01 ` Pratyush Yadav
  1 sibling, 0 replies; 4+ messages in thread
From: Stefan Haller @ 2020-10-13 19:08 UTC (permalink / raw)
  To: git; +Cc: me

On 13.10.20 21:02, Stefan Haller wrote:
> This option is supposed to make a Tcl/Tk app look more like a native app
> for the respective platform. This doesn't seem to work on Mac, it looks
> worse than the non-ttk appearance (for instance, the colored pane
> headers are grey).
> 
> Users who really prefer the ttk look can still turn it on with the
> gui.usettk config.

Here's a screenshot with ttk on:

    https://cp.sync.com/dl/8c7693bc0/huvbc4f8-mkp8xzqc-nsevkr22-i4t4whwb

And this is with ttk off:

    https://cp.sync.com/dl/3a62604d0/756hqje2-mqqbanvc-aq3ghjd6-g7hw49xx

-Stefan


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] git-gui: Make usettk off by default on Mac OS X
  2020-10-13 19:02 [PATCH] git-gui: Make usettk off by default on Mac OS X Stefan Haller
  2020-10-13 19:08 ` Stefan Haller
@ 2020-10-14 10:01 ` Pratyush Yadav
  2020-10-14 10:27   ` Stefan Haller
  1 sibling, 1 reply; 4+ messages in thread
From: Pratyush Yadav @ 2020-10-14 10:01 UTC (permalink / raw)
  To: Stefan Haller; +Cc: git

Hi Stefan,

On 13/10/20 09:02PM, Stefan Haller wrote:
> This option is supposed to make a Tcl/Tk app look more like a native app
> for the respective platform. This doesn't seem to work on Mac, it looks
> worse than the non-ttk appearance (for instance, the colored pane
> headers are grey).

I think we should actually fix the root of the problem instead of just 
fixing the symptoms by disabling ttk.

There were recently some changes to how git-gui works with ttk in commit 
c02efc1 (git-gui: improve dark mode support, 2020-09-26). Are you 
running git-gui with that commit? If yes, what results do you see with 
it reverted. If no, what results do you see with it applied?

> Users who really prefer the ttk look can still turn it on with the
> gui.usettk config.
> 
> Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
> ---
>  git-gui.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git-gui.sh b/git-gui.sh
> index 867b8ce..f7e13ca 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -897,7 +897,7 @@ set default_config(gui.fontui) [font configure font_ui]
>  set default_config(gui.fontdiff) [font configure font_diff]
>  # TODO: this option should be added to the git-config documentation
>  set default_config(gui.maxfilesdisplayed) 5000
> -set default_config(gui.usettk) 1
> +set default_config(gui.usettk) [expr ![is_MacOSX]]
>  set default_config(gui.warndetachedcommit) 1
>  set default_config(gui.tabsize) 8
>  set font_descs {
> -- 
> 2.29.0.rc1
> 

-- 
Regards,
Pratyush Yadav

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] git-gui: Make usettk off by default on Mac OS X
  2020-10-14 10:01 ` Pratyush Yadav
@ 2020-10-14 10:27   ` Stefan Haller
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Haller @ 2020-10-14 10:27 UTC (permalink / raw)
  To: Pratyush Yadav; +Cc: git

On 14.10.20 12:01, Pratyush Yadav wrote:
> Hi Stefan,
> 
> On 13/10/20 09:02PM, Stefan Haller wrote:
>> This option is supposed to make a Tcl/Tk app look more like a native app
>> for the respective platform. This doesn't seem to work on Mac, it looks
>> worse than the non-ttk appearance (for instance, the colored pane
>> headers are grey).
> 
> I think we should actually fix the root of the problem instead of just
> fixing the symptoms by disabling ttk.
> 
> There were recently some changes to how git-gui works with ttk in commit
> c02efc1 (git-gui: improve dark mode support, 2020-09-26). Are you
> running git-gui with that commit? If yes, what results do you see with
> it reverted. If no, what results do you see with it applied?

I agree that it would be better to fix the root cause; my suspicion was 
that the themed widgets on Mac simply don't support a background color, 
but I didn't investigate that any further.

I was indeed not running with "git-gui: improve dark mode support" yet, 
but applying it didn't make a difference.

I'm also happy to drop this if you are uncomfortable with it; it's easy 
enough to set gui.usettk to 0 to fix the problem locally.

Best,
Stefan

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-14 10:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-13 19:02 [PATCH] git-gui: Make usettk off by default on Mac OS X Stefan Haller
2020-10-13 19:08 ` Stefan Haller
2020-10-14 10:01 ` Pratyush Yadav
2020-10-14 10:27   ` Stefan Haller

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.version-control.git
	nntp://ie5yzdi7fg72h7s4sdcztq5evakq23rdt33mfyfcddc5u3ndnw24ogqd.onion/inbox.comp.version-control.git
	nntp://4uok3hntl7oi7b4uf4rtfwefqeexfzil2w6kgk2jn5z2f764irre7byd.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git