From: Aaron Pelly <aaron@pelly.co>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: Expanding Includes in .gitignore
Date: Fri, 28 Oct 2016 09:28:23 +1300 [thread overview]
Message-ID: <b20b458c-440d-df09-d2c7-e510ac20492c@pelly.co> (raw)
In-Reply-To: <20161027105026.e752znq5jv5a6xea@sigill.intra.peff.net>
On 27/10/16 23:50, Jeff King wrote:
> I'd shy away from an actual include directive, as it raises a lot of
> complications:
I'm leaning that way now too.
> - we parse possibly-hostile .gitignore files from cloned repositories.
> What happens when I include ask to include /etc/passwd? Probably
> nothing, but there are setups where it might matter (e.g., something
> like Travis that auto-builds untrusted repositories, and you could
> potentially leak the contents of files via error messages). It's
> nice to avoid the issue entirely.
I understand the issue.
It's not obvious to me how using a .d solves this problem though.
> - finding a backwards-compatible syntax
using .d directories solves this nicely in my opinion
> Whereas letting any of the user- or repo-level exclude files be a
> directory, and simply reading all of the files inside, seems simple and
> obvious.
Apart from backwards compatibility, unless there's something I'm missing.
> If you go that route, it probably makes sense to teach
> gitattributes the same trick.
Understood. I'll keep that in mind.
>> In the case of a directory the plan would be to add links to files
>> stored/sourced elsewhere. This does pose a precedence question which I
>> haven't thought about yet, but probably makes it too hard for the
>> limited value it brings.
>
> I think the normal behavior in such "foo.d" directory is to just sort
> the contents lexically and read them in order, as if they were all
> concatenated together, and with no recursion. I.e., behave "as if" the
> user had run "cat $dir/*".
>
> That lets you handle precedence via the filenames (or symlink names).
That was my thinking at first, but I didn't want to bias the discussion.
> It
> can't handle all cases (some items in "00foo" want precedence over "01bar"
> and vice versa), but I don't think there's an easy solution. That's a
> good sign that one or more of the files should be broken up.
I've been burned by this myself by packages interfering with each other
in /etc/sysctl.d
Could we put this down to caveat emptor? I think this sorting should be
intuitive to most people these days, and simple to document and comprehend.
next prev parent reply other threads:[~2016-10-27 20:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 0:22 Expanding Includes in .gitignore Aaron Pelly
2016-10-27 2:22 ` Stefan Beller
2016-10-27 9:51 ` Aaron Pelly
2016-10-27 8:19 ` Alexei Lozovsky
2016-10-27 10:33 ` Aaron Pelly
2016-10-27 10:50 ` Jeff King
2016-10-27 19:48 ` Jacob Keller
2016-10-27 20:59 ` Aaron Pelly
2016-10-27 21:04 ` Jeff King
2016-10-27 21:26 ` Aaron Pelly
2016-10-27 21:39 ` Jacob Keller
2016-10-30 3:09 ` Duy Nguyen
2016-10-27 20:28 ` Aaron Pelly [this message]
2016-10-27 20:55 ` Jeff King
2016-10-27 21:07 ` Jeff King
2016-10-27 22:30 ` Aaron Pelly
2016-10-27 23:07 ` Aaron Pelly
2016-10-28 2:54 ` Junio C Hamano
2016-10-28 9:32 ` Aaron Pelly
2016-10-30 3:16 ` Duy Nguyen
2016-10-30 12:54 ` Jeff King
2016-10-27 21:55 ` Aaron Pelly
2016-10-27 22:17 ` Aaron Pelly
2016-10-28 8:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b20b458c-440d-df09-d2c7-e510ac20492c@pelly.co \
--to=aaron@pelly.co \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).