From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, felipe.contreras@gmail.com,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Emily Shaffer" <emilyshaffer@google.com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 1/2] make: add install-stripped target
Date: Fri, 27 Aug 2021 14:57:56 +0700 [thread overview]
Message-ID: <b2005b0f-9181-526b-ebf5-58fca44299b5@gmail.com> (raw)
In-Reply-To: <xmqq8s0odl5l.fsf@gitster.g>
On 27/08/21 03.08, Junio C Hamano wrote:
> It also depends on "strip" not to break handlinks to the same
> binary. "git" is linked to many built-in command binary like
> "git-cat-file" and "git-remote-$curl" for various protocols are
> installed by creating links to "git-remote-http". It seems that the
> "strip" command from GNU binutils package strips such a binary
> in-place, but I do not think there is no fundamental reason to
> believe that everybody else's "strip" would behave that way.
>
Maybe hardlinks?
> I would have expected that 'install-stripped' and 'install' targets
> would run the same recipe, and when $(install_bindir_programs) are
> installed in $(bindir) using $(INSTALL), we would optionally pass
> the '--strip' option to the $(INSTALL) program when the recipe is
> run for the install-stripped target. All the tricky symlinking,
> hardlinking and copying happens only on the result of that step, and
> the strip step should happen before that, I would think.
>
Did you mean copying recipe of 'install' to 'install-stripped' and the
latter s/$(INSTALL)/$(INSTALL -s --strip-program="$(STRIP)"/)?
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-08-27 7:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 11:38 [PATCH 0/2] make: install stripped Git Bagas Sanjaya
2021-08-26 11:38 ` [PATCH 1/2] make: add install-stripped target Bagas Sanjaya
2021-08-26 20:08 ` Junio C Hamano
2021-08-27 7:57 ` Bagas Sanjaya [this message]
2021-08-27 12:41 ` Đoàn Trần Công Danh
2021-08-26 11:38 ` [PATCH 2/2] make: delete strip target Bagas Sanjaya
2021-08-26 19:36 ` Ævar Arnfjörð Bjarmason
2021-08-26 20:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2005b0f-9181-526b-ebf5-58fca44299b5@gmail.com \
--to=bagasdotme@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=emilyshaffer@google.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).