From: Derrick Stolee <stolee@gmail.com>
To: Ananya Krishna Maram <ananyakittu1997@gmail.com>,
christian.couder@gmail.com, git@vger.kernel.org,
Johannes.Schindelin@gmx.de
Subject: Re: [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files
Date: Mon, 8 Oct 2018 13:13:26 -0400 [thread overview]
Message-ID: <b1824db3-1c0d-6851-2f5a-800cc88ee50f@gmail.com> (raw)
In-Reply-To: <20181008170505.GA13134@manohar-ssh>
On 10/8/2018 1:05 PM, Ananya Krishna Maram wrote:
> Hi All,
Hello, Ananya! Welcome.
> I was searching through #leftovers and found this.
> https://public-inbox.org/git/CABPp-BGVVXcbZX44er6TO-PUsfEN_6GNYJ1U5cuoN9deaA48OQ@mail.gmail.com/
>
> This patch address the task discussed in the above link.
The discussion above seems to not be intended for your commit message,
but it does show up when I run `git am` and provide your email as input.
The typical way to avoid this is to place all commentary below the "---"
that signifies the commit message is over.
> From: Ananya Krishan Maram <ananyakittu1997@gmail.com>
>
> skip the #include of git-compat-util.h since all .c files include it.
>
> Signed-off-by: Ananya Krishna Maram <ananyakittu1997@gmail.com>
> ---
> advice.h | 1 -
> commit-graph.h | 1 -
> hash.h | 1 -
> pkt-line.h | 1 -
> t/helper/test-tool.h | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/advice.h b/advice.h
> index ab24df0fd..09148baa6 100644
> --- a/advice.h
> +++ b/advice.h
> @@ -1,7 +1,6 @@
> #ifndef ADVICE_H
> #define ADVICE_H
>
> -#include "git-compat-util.h"
>
> extern int advice_push_update_rejected;
> extern int advice_push_non_ff_current;
> diff --git a/commit-graph.h b/commit-graph.h
> index b05047676..0e93c2bed 100644
> --- a/commit-graph.h
> +++ b/commit-graph.h
> @@ -1,7 +1,6 @@
> #ifndef COMMIT_GRAPH_H
> #define COMMIT_GRAPH_H
>
> -#include "git-compat-util.h"
> #include "repository.h"
> #include "string-list.h"
> #include "cache.h"
> diff --git a/hash.h b/hash.h
> index 7c8238bc2..9a4334c5d 100644
> --- a/hash.h
> +++ b/hash.h
> @@ -1,7 +1,6 @@
> #ifndef HASH_H
> #define HASH_H
>
> -#include "git-compat-util.h"
>
> #if defined(SHA1_PPC)
> #include "ppc/sha1.h"
> diff --git a/pkt-line.h b/pkt-line.h
> index 5b28d4347..fdd316494 100644
> --- a/pkt-line.h
> +++ b/pkt-line.h
> @@ -1,7 +1,6 @@
> #ifndef PKTLINE_H
> #define PKTLINE_H
>
> -#include "git-compat-util.h"
> #include "strbuf.h"
>
> /*
> diff --git a/t/helper/test-tool.h b/t/helper/test-tool.h
> index e07495727..24e0a1589 100644
> --- a/t/helper/test-tool.h
> +++ b/t/helper/test-tool.h
> @@ -1,7 +1,6 @@
> #ifndef __TEST_TOOL_H__
> #define __TEST_TOOL_H__
>
> -#include "git-compat-util.h"
>
> int cmd__chmtime(int argc, const char **argv);
> int cmd__config(int argc, const char **argv);
I applied these changes locally and confirmed the code compiles, so all
.c files including these _do_ include git-compat-util.h properly.
Thanks,
-Stolee
next prev parent reply other threads:[~2018-10-08 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 17:05 [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files Ananya Krishna Maram
2018-10-08 17:13 ` Derrick Stolee [this message]
2018-10-09 2:16 ` Ananya Krishna Maram
2018-10-09 10:13 ` Junio C Hamano
2018-10-10 8:06 ` Johannes Schindelin
2018-10-10 8:46 ` Junio C Hamano
2018-10-10 9:13 ` Christian Couder
2018-10-10 12:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1824db3-1c0d-6851-2f5a-800cc88ee50f@gmail.com \
--to=stolee@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=ananyakittu1997@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).