From: "Catalin Marinas" <catalin.marinas@gmail.com>
To: "Yann Dirson" <ydirson@altern.org>
Cc: "Karl Hasselström" <kha@treskal.com>, "GIT list" <git@vger.kernel.org>
Subject: Re: stgit restrictions on patch names
Date: Mon, 29 Oct 2007 16:14:34 +0000 [thread overview]
Message-ID: <b0943d9e0710290914p4163ffabt5767fdb2ab8d91d4@mail.gmail.com> (raw)
In-Reply-To: <20071025194808.GV26436@nan92-1-81-57-214-146.fbx.proxad.net>
On 25/10/2007, Yann Dirson <ydirson@altern.org> wrote:
> Looks like stgit is now more picky on patch names than in used to be:
It's not that we explicitly disallows "+" but I think I tried to avoid
some wrong patch names but was too lazy to create a better regexp.
As a quick fix, we could re-generate a patch name if it is invalid.
> => the result of the cloning operation is a partial clone. Do we want to:
>
> - implement a mechanism for checking beforehand that the operation
> will not fail ? Seems awkward to duplicate checks already found
> elsewhere.
>
> - wait for proper transactions so we can rollback on error ?
>
> - on clone error, delete the newly-created stack ? I'd vote for this
> one, until the previous one gets done.
I think the last one is the simplest to implement, while the second is
nicer, I've never found the time to investigate it properly.
--
Catalin
prev parent reply other threads:[~2007-10-29 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 19:48 stgit restrictions on patch names Yann Dirson
2007-10-26 7:29 ` Karl Hasselström
2007-10-29 16:14 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0710290914p4163ffabt5767fdb2ab8d91d4@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).