git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philip Oakley <philipoakley@iee.email>
To: Angelo Borsotti <angelo.borsotti@gmail.com>, git <git@vger.kernel.org>
Subject: Re: Git add documentation error
Date: Thu, 27 Oct 2022 16:10:48 +0100	[thread overview]
Message-ID: <b0008377-2cb5-72ff-e94b-8182065b3436@iee.email> (raw)
In-Reply-To: <CAB9Jk9Ay2PPEYKve3DXVmG__yZjO1mgh1MxaKA+wfsF0ZvKRqA@mail.gmail.com>

Hi,
On 27/10/2022 12:53, Angelo Borsotti wrote:
> Hello,
>
> the reference manual for the "git add" command does not
> specify what that command does when applied to an
> unmodified file.

I presume that this file is already tracked..
> By testing this, I have seen that it does not add the file
> to the index, 

How was this tested?

If you have no changes, thaen the status diff will have no mention of
that file.
Perhaps change the tracked mode bits to see if that is noticed (note
though, not all mode bits are tracked..)
> and consequently it does not add it when a
> subsequent commit is done.

I suspect this is a subtle mental model misunderstanding about the
distinction between a commit as a snapshot, and a commit being reported
as the diff relative to its parent (and here, there is none, if the file
is unmodified)
> I think that this should be documented.

A test script with sample output would help here.
--
Philip



  reply	other threads:[~2022-10-27 15:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 11:53 Git add documentation error Angelo Borsotti
2022-10-27 15:10 ` Philip Oakley [this message]
     [not found]   ` <CAB9Jk9BBddd5d0wKFB0eJw1OMMAQj88J9Bn1Yn1rbK_F1mEs1A@mail.gmail.com>
2022-10-27 16:16     ` Philip Oakley
2022-10-27 16:57       ` Angelo Borsotti
2022-10-27 17:28         ` Junio C Hamano
2022-10-27 17:46           ` Angelo Borsotti
2022-10-27 18:44             ` Junio C Hamano
2022-10-27 19:15               ` Angelo Borsotti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0008377-2cb5-72ff-e94b-8182065b3436@iee.email \
    --to=philipoakley@iee.email \
    --cc=angelo.borsotti@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).