Hi, On Fri, 4 Apr 2008, Junio C Hamano wrote: > Kristian Høgsberg writes: > > > ... I know I just threw it over the fence, but Daniel picked it up and > > got it a lot closer to working? Did it fall through the cracks or is > > it just 1.5.6 material? > > If I recall correctly, "a lot closer to working" happened way after > 1.5.5 merge window closed, so it definitely is not 1.5.5 material. > > Judging from the fact that we recently had to deal with the fallouts of > C rewrites that happened during the 1.5.4 timeframe, I would have to say > that any C rewrite of a substantial and important program needs to be > cooked at least for one (or preferably two cycles, especially we are > trying to have shorter cycles) in 'next'. That would mean that you'd have to merge it into 'next'. And rather sooner than later, since everything else would lead to a dragging out of the timeline. As it happens, until you called out the 'please test master' phase, I was running with builtin clone, and did not find it lacking. Although I have to admit that I have some cleanups, and I haven't merged with Daniel in a long time. And I do not do anything particularly fancy, such as shallow clone or shared clone. Ciao, Dscho "who hopes that the please-test-master phase is over soon"