From: Julian Phillips <julian@quantumfyre.co.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH v2] fetch: Speed up fetch by rewriting find_non_local_tags
Date: Thu, 17 Sep 2009 02:30:38 +0100 (BST) [thread overview]
Message-ID: <alpine.LNX.2.00.0909170227160.15719@reaper.quantumfyre.co.uk> (raw)
In-Reply-To: <alpine.LNX.2.00.0909170039410.14993@reaper.quantumfyre.co.uk>
On Thu, 17 Sep 2009, Julian Phillips wrote:
> On Wed, 16 Sep 2009, Junio C Hamano wrote:
>
>> I am just curious. How would a "just one item lookbehind" code perform
>> compared to this one?
>
> The code you wrote ealier is almost the same as the string_list version,
> ~ 4.3s, so very marginally slower but a lot less code change. Personally
> I'd be happy with any of the three, so long as I don't have to wait 30s to
> find out that nothing's happened at $dayjob anymore ;)
FWIW: I've Just modified my v2 patch to make use of the requirement that
the peeled ref immediately follow the base ref, and it's now ~4.1s and
should use less memory than the original too. I won't bother posting it
unless someone thinks it worth it though.
--
Julian
---
Taxes, n.:
Of life's two certainties, the only one for which you can get
an extension.
next prev parent reply other threads:[~2009-09-17 1:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 7:53 [RFC/PATCH 0/2] Speed up fetch with large number of tags Julian Phillips
2009-09-16 7:53 ` [RFC/PATCH 1/2] ref-dict: Add a set of functions for working with a ref dictionary Julian Phillips
2009-09-16 7:53 ` [RFC/PATCH 2/2] fetch: Speed up fetch by using " Julian Phillips
2009-09-16 9:44 ` [RFC/PATCH 0/2] Speed up fetch with large number of tags Junio C Hamano
2009-09-16 22:32 ` Julian Phillips
2009-09-16 22:42 ` Shawn O. Pearce
2009-09-16 22:52 ` Junio C Hamano
2009-09-16 23:03 ` Shawn O. Pearce
2009-09-16 23:19 ` Junio C Hamano
2009-09-16 22:53 ` [RFC/PATCH v2] fetch: Speed up fetch by rewriting find_non_local_tags Julian Phillips
2009-09-16 23:15 ` Junio C Hamano
2009-09-16 23:46 ` Julian Phillips
2009-09-17 1:30 ` Julian Phillips [this message]
2009-09-17 7:13 ` Johan Herland
2009-09-17 7:33 ` [RFC/PATCH v3] " Julian Phillips
2009-09-16 22:46 ` [RFC/PATCH 0/2] Speed up fetch with large number of tags Shawn O. Pearce
2009-09-22 20:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.0909170227160.15719@reaper.quantumfyre.co.uk \
--to=julian@quantumfyre.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).