From: Daniel Barkalow <barkalow@iabervon.org>
To: Junio C Hamano <junio@pobox.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 4/8] Add a function to set a non-default work tree
Date: Sun, 20 Apr 2008 15:52:30 -0400 (EDT) [thread overview]
Message-ID: <alpine.LNX.1.00.0804201546340.19665@iabervon.org> (raw)
In-Reply-To: <7vprslcdxf.fsf@gitster.siamese.dyndns.org>
On Sat, 19 Apr 2008, Junio C Hamano wrote:
> Daniel Barkalow <barkalow@iabervon.org> writes:
>
> > Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
> > ---
> > cache.h | 1 +
> > environment.c | 6 ++++++
> > 2 files changed, 7 insertions(+), 0 deletions(-)
> >
> > diff --git a/cache.h b/cache.h
> > index 96dcb49..d88a4e2 100644
> > --- a/cache.h
> > +++ b/cache.h
> > @@ -311,6 +311,7 @@ extern char *get_index_file(void);
> > extern char *get_graft_file(void);
> > extern int set_git_dir(const char *path);
> > extern const char *get_git_work_tree(void);
> > +extern void set_git_work_tree(const char *tree);
> >
> > #define ALTERNATE_DB_ENVIRONMENT "GIT_ALTERNATE_OBJECT_DIRECTORIES"
> >
> > diff --git a/environment.c b/environment.c
> > index 6739a3f..d6c6a6b 100644
> > --- a/environment.c
> > +++ b/environment.c
> > @@ -81,6 +81,12 @@ const char *get_git_dir(void)
> > return git_dir;
> > }
> >
> > +void set_git_work_tree(const char *new_work_tree)
> > +{
> > + get_git_work_tree(); /* make sure it's initialized */
> > + work_tree = xstrdup(make_absolute_path(new_work_tree));
> > +}
> > +
>
> Somehow this feels wrong. Maybe you would need to move that "static int"
> variable inside get_git_work_tree() outside so that you can reset from
> this new function at will?
Yeah, that's better.
> How should the setting of new work tree from sideways using this interface
> interact with bareness of the repository?
I'm only using it before any initialization and when I'm going to force
the repository (which doesn't even exist yet; I haven't set git_dir let
alone created it, let alone looked at its configuration) to be bare, so I
hadn't considered that.
> Should it reset is_bare_repository_cfg to zero? Should it refuse to set a
> work tree if is_bare_repository_cfg is true already?
is_bare_repository_cfg starts out -1 (not yet specified); this should
probably set it to false and require that it not have been specified
previously.
-Daniel
*This .sig left intentionally blank*
next prev parent reply other threads:[~2008-04-20 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 23:32 [PATCH 4/8] Add a function to set a non-default work tree Daniel Barkalow
2008-04-19 17:33 ` Johan Herland
2008-04-20 5:07 ` Junio C Hamano
2008-04-20 19:52 ` Daniel Barkalow [this message]
2008-04-22 0:09 ` Junio C Hamano
2008-04-22 3:47 ` Daniel Barkalow
-- strict thread matches above, loose matches on Subject: below --
2008-04-27 17:39 Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.1.00.0804201546340.19665@iabervon.org \
--to=barkalow@iabervon.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).