From: Daniel Barkalow <barkalow@iabervon.org>
To: Johan Herland <johan@herland.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 0/8] builtin-clone
Date: Thu, 17 Apr 2008 20:56:51 -0400 (EDT) [thread overview]
Message-ID: <alpine.LNX.1.00.0804172052300.19665@iabervon.org> (raw)
In-Reply-To: <200804180250.48544.johan@herland.net>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2388 bytes --]
On Fri, 18 Apr 2008, Johan Herland wrote:
> On Friday 18 April 2008, Daniel Barkalow wrote:
> > This is my latest version, rebased approximately on current master (or
> > recent maint, I guess). It's missing all of Johan's stuff, which is tests
> > for stuff I've fixed
>
> Does this mean you no longer need the tests, or that you want me to resend?
I have them, but my patch-sending process isn't set up for sending other
people's patches without forging their email, and I wanted to get this
series out, and they're not critical, so I skipped them for now.
> > and (after this series) a series to make the clone generate packed refs.
>
> I'll resend the series once your work has settled down and landed in "next".
>
> BTW, I noticed in your repo (at iabervon.org) that you put "if (0)" around
> the code generating packed-refs (using the old one instead), and added the
> following note to the commit message:
It was really mostly that the version I have in there doesn't pass the
tests, due to not having the thing to filter packed refs.
> I made this compile-time configurable because I'm not sure we want to
> pack unconditionally.
>
> We should probably figure out the right thing to do here. AFAICS,
> compile-time configurability is only a temporary measure, and we basically
> have to choose between:
>
> 1. Add a command-line option (and config variable?) for controlling
> whether "git clone" generates packed refs.
>
> 2. Make "git clone" unconditionally generate packed refs.
>
> Currently, I'm leaning towards (2), since I don't think there's enough
> drawbacks with generating packed-refs to justify adding a command-line
> option. AFAICS, the only drawback is that reflogs aren't
> created/initialized on clone, but I got the feeling that this was not
> particularly important. Quoting Junio from an earlier thread:
>
> Not writing reflogs is a _different_ behaviour from the previous, but I
> suspect it might even be an improvement. When you have 1000 remote
> branches, probably most of them are not even active.
>
> If there are good arguments for going with (1), I'd love to hear them.
I think it's fine, actually (now that you've not test corrections that
work for it); but I'd like to have builtin-clone land without any changes
in behaviour, and then get this sort of improvement.
-Daniel
*This .sig left intentionally blank*
next prev parent reply other threads:[~2008-04-18 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 23:32 [PATCH 0/8] builtin-clone Daniel Barkalow
2008-04-18 0:50 ` Johan Herland
2008-04-18 0:56 ` Daniel Barkalow [this message]
2008-04-18 1:14 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.1.00.0804172052300.19665@iabervon.org \
--to=barkalow@iabervon.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).