mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Robert P. J. Day" <>
To: Junio C Hamano <>
Cc: Jeff King <>, Git Mailing list <>
Subject: Re: is it "git gc --prune=now" or "git gc --prune=all"?
Date: Sat, 9 Mar 2019 13:13:41 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.21.1903091309130.16641@localhost.localdomain> (raw)
In-Reply-To: <>

On Wed, 6 Mar 2019, Junio C Hamano wrote:

> Jeff King <> writes:
> > ... I do think the documentation should recommend "now". Possibly
> > builtin/gc.c should be smarter about recognizing "all" in the
> > conditional you quoted, too, though I don't know that it's all
> > that important (especially if we tweak the documentation).
> Yup, as the placeholder for the value is labeled as "<date>", "now"
> would be the one we should be encouraging.

  i can submit an obviously trivial patch for that -- i can see in
date.c the equally valid alternatives:

    int parse_expiry_date(const char *date, timestamp_t *timestamp)
        int errors = 0;

        if (!strcmp(date, "never") || !strcmp(date, "false"))
                *timestamp = 0;
        else if (!strcmp(date, "all") || !strcmp(date, "now"))
        ... snip ...

  is the preference to simply list both alternatives, or to
*encourage* the more intuitive "now" and "never" values while politely
deprecating the others? the impression i get is the latter.



Robert P. J. Day                                 Ottawa, Ontario, CANADA


  reply	other threads:[~2019-03-09 18:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-02  8:26 is it "git gc --prune=now" or "git gc --prune=all"? Robert P. J. Day
2019-03-05  5:03 ` Jeff King
2019-03-06  0:08   ` Junio C Hamano
2019-03-09 18:13     ` Robert P. J. Day [this message]
2019-03-11  2:18       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.21.1903091309130.16641@localhost.localdomain \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).