From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCH] Refactor recv_sideband()
Date: Tue, 14 Jun 2016 12:43:56 -0400 (EDT)
Message-ID: <alpine.LFD.2.20.1606141242480.1714@knanqh.ubzr>
References: <20160613195224.13398-1-lfleischer@lfos.de> <alpine.LFD.2.20.1606131704060.1714@knanqh.ubzr> <alpine.DEB.2.20.1606141542040.22630@virtualbox> <alpine.LFD.2.20.1606141059420.1714@knanqh.ubzr> <Cq7rbYgOpb0CVCq7sbGmpL@videotron.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Cc: Lukas Fleischer <lfleischer@lfos.de>, git@vger.kernel.org,
	Johannes Sixt <j6t@kdbg.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
X-From: git-owner@vger.kernel.org Tue Jun 14 18:56:01 2016
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1bCrRc-0007sG-TG
	for gcvg-git-2@plane.gmane.org; Tue, 14 Jun 2016 18:44:05 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751395AbcFNQoA (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Tue, 14 Jun 2016 12:44:00 -0400
Received: from alt32.smtp-out.videotron.ca ([24.53.0.21]:61975 "EHLO
	alt32.smtp-out.videotron.ca" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751364AbcFNQn7 (ORCPT
	<rfc822;git@vger.kernel.org>); Tue, 14 Jun 2016 12:43:59 -0400
Received: from yoda.home ([96.23.157.65])
	by Videotron with SMTP
	id CrRUbV23ZJE3dCrRVb6lYu; Tue, 14 Jun 2016 12:43:58 -0400
X-Authority-Analysis: v=2.1 cv=DYG30qZW c=1 sm=1 tr=0
 a=keA3yYpnlypCNW5BNWqu+w==:117 a=keA3yYpnlypCNW5BNWqu+w==:17
 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10
 a=pD_ry4oyNxEA:10 a=dfl5SRnfqdFPOpq08UoA:9 a=CjuIK1q_8ugA:10
Received: from xanadu.home (xanadu.home [192.168.2.2])
	by yoda.home (Postfix) with ESMTPSA id 26FC82DA01A5;
	Tue, 14 Jun 2016 12:43:56 -0400 (EDT)
In-Reply-To: <Cq7rbYgOpb0CVCq7sbGmpL@videotron.ca>
User-Agent: Alpine 2.20 (LFD 67 2015-01-07)
X-CMAE-Envelope: MS4wfKL0fQSGKBg/D02pZZPx7AcVi9bXnlpS87HDvvoBJzZiSOcOOeLsimIRQIC4HHsDQgdM2yxXABaAUNd73/VRfIKvbTibw4/qBpcmKoGwfIg4+0TPU615
 ZM+DKWloUbHbDsAoB6Xh64EMmuKqJ5XmsIWJaxyTKMPYYMJwQPqkw/irhaPDDWoXt+54j9nPNEDR3NsjJXLSKOkdRoljtn782ZiahLTSi6HmX+Tb6K/i1d7p
 bj8CXrLAEIOB0v9flEl8Cg==
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/297306>

On Tue, 14 Jun 2016, Johannes Schindelin wrote:

> Hi Nico,
> 
> On Tue, 14 Jun 2016, Nicolas Pitre wrote:
> 
> > On Tue, 14 Jun 2016, Johannes Schindelin wrote:
> > 
> > > On Mon, 13 Jun 2016, Nicolas Pitre wrote:
> > > 
> > > > On Mon, 13 Jun 2016, Lukas Fleischer wrote:
> > > > 
> > > > > Improve the readability of recv_sideband() significantly by
> > > > > replacing fragile buffer manipulations with more sophisticated
> > > > > format strings.  Also, reorganize the overall control flow, remove
> > > > > some superfluous variables and replace a custom implementation of
> > > > > strpbrk() with a call to the standard C library function.
> > > > > 
> > > > > Signed-off-by: Lukas Fleischer <lfleischer@lfos.de>
> > > > 
> > > > The previous code was a total abomination, even if I happen to know
> > > > who wrote it.
> > > 
> > > Let's give Junio a break, okay? He does a kick-ass job at maintaining
> > > Git.  What we see here is simply good software development, nothing
> > > more, nothing less: an initial, working code being improved. No need
> > > to make the original author feel bad... :-)
> > 
> > In case my sarcasm wasn't clear, _I_ am the author of the alluded
> > abomination.
> 
> Sorry, I did not catch that. I just looked at
> 583b7ea31b7c16f872b178d541591ab816d16f85 and felt that we could be nicer
> to Junio...

Oh, the initial code from Junio was sane enough. I made a mess of it 
afterwards.


Nicolas