From: Nicolas Pitre <email@example.com> To: Duy Nguyen <firstname.lastname@example.org> Cc: Git Mailing List <email@example.com>, Jeff King <firstname.lastname@example.org> Subject: Re: pack corruption post-mortem Date: Sun, 20 Oct 2013 17:08:30 -0400 (EDT) [thread overview] Message-ID: <alpine.LFD.email@example.com> (raw) In-Reply-To: <CACsJy8AATr9KfFN6x0E8mYsBmWhVmD=kaXgBmnFTiyww3MS8WQ@mail.gmail.com> On Sun, 20 Oct 2013, Duy Nguyen wrote: > On Sat, Oct 19, 2013 at 9:41 PM, Nicolas Pitre <firstname.lastname@example.org> wrote: > > On Sat, 19 Oct 2013, Duy Nguyen wrote: > > The SHA1 used in the name of the pack file is actually the SHA1 checksum > > of the SHA1 table. > > > > The path and ident tables are already protected by the CRC32 in the zlib > > deflated stream. > > > > Normal objects are also zlib deflated (except for their header) but you > > need to inflate them in order to have this CRC verified, which the pack > > data copy tries to avoid. Hence the separate CRC32 in the index file in > > that case. > > OK slight change in the subject, what about reading code (i.e. > sha1_file.c)? With v2 crc32 is verified by object inflate code. With > v4 trees or commits, because we store some (or all) data outside of > the deflated stream, we will not benefit from crc32 verifcation > previously done for all trees and commits. Should we perform explict > crc32 check when reading v4 trees and commits (and maybe verify the > sha-1 table too)? I suppose that we should... at some point. I did the SHA1 table check only for index-pack and unpack-objects in my latest patch. Adding it to check_packed_git_idx() as well should be trivial. I'm not sure about the best way to do systematic checks on tree objects though. We have both the CRC32 recorded in the index file and the object SHA1 recorded in the SHA1 table. But any of them needs to be computed as we walk the object and we currently havn't found the best way to do that yet. So I'd suggest postponing this until the tree walk is properly implemented to perform well first. Nicolas
next prev parent reply other threads:[~2013-10-20 21:08 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-10-16 8:34 Jeff King 2013-10-16 8:59 ` Duy Nguyen 2013-10-16 15:41 ` Martin Fick 2013-10-17 0:35 ` Jeff King 2013-10-17 15:47 ` Junio C Hamano 2013-10-25 7:55 ` Jeff King 2013-10-17 1:06 ` Duy Nguyen 2013-10-19 10:32 ` Duy Nguyen 2013-10-19 14:41 ` Nicolas Pitre 2013-10-19 19:17 ` Shawn Pearce 2013-10-20 20:56 ` Nicolas Pitre 2013-10-20 4:44 ` Duy Nguyen 2013-10-20 21:08 ` Nicolas Pitre [this message] 2015-04-01 21:08 ` [PATCH] howto: document more tools for recovery corruption Jeff King 2015-04-01 22:21 ` Junio C Hamano 2015-04-02 0:49 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.LFD.email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: pack corruption post-mortem' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).