From: Nicolas Pitre <nico@fluxnic.net>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] unpack_entry: do not die when we fail to apply a delta
Date: Thu, 13 Jun 2013 20:05:21 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.03.1306132004090.18597@syhkavp.arg> (raw)
In-Reply-To: <20130613232608.GA9844@sigill.intra.peff.net>
On Thu, 13 Jun 2013, Jeff King wrote:
> When we try to load an object from disk and fail, our
> general strategy is to see if we can get it from somewhere
> else (e.g., a loose object). That lets users fix corruption
> problems by copying known-good versions of objects into the
> object database.
>
> We already handle the case where we were not able to read
> the delta from disk. However, when we find that the delta we
> read does not apply, we simply die. This case is harder to
> trigger, as corruption in the delta data itself would
> trigger a crc error from zlib. However, a corruption that
> pointed us at the wrong delta base might cause it.
>
> We can do the same "fail and try to find the object
> elsewhere" trick instead of dying. This not only gives us a
> chance to recover, but also puts us on code paths that will
> alert the user to the problem (with the current message,
> they do not even know which sha1 caused the problem).
>
> Signed-off-by: Jeff King <peff@peff.net>
That makes sense.
Could you produce a test case to go along with this change?
> ---
> I needed this earlier today to recover from a corrupted packfile (I
> fortunately had an older version of the repo in backups). Still tracking
> down the exact nature of the corruption.
>
> sha1_file.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/sha1_file.c b/sha1_file.c
> index 5c08701..d458708 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -2135,8 +2135,17 @@ void *unpack_entry(struct packed_git *p, off_t obj_offset,
> data = patch_delta(base, base_size,
> delta_data, delta_size,
> &size);
> +
> + /*
> + * We could not apply the delta; warn the user, but keep going.
> + * Our failure will be noticed either in the next iteration of
> + * the loop, or if this is the final delta, in the caller when
> + * we return NULL. Those code paths will take care of making
> + * a more explicit warning and retrying with another copy of
> + * the object.
> + */
> if (!data)
> - die("failed to apply delta");
> + error("failed to apply delta");
>
> free(delta_data);
> }
> --
> 1.8.3.rc2.14.g7eee6b3
>
next prev parent reply other threads:[~2013-06-14 0:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 23:26 [PATCH] unpack_entry: do not die when we fail to apply a delta Jeff King
2013-06-14 0:05 ` Nicolas Pitre [this message]
2013-06-14 21:49 ` [PATCH 0/2] recover from "failed to apply delta" Jeff King
2013-06-14 21:51 ` [PATCH 1/2] t5303: drop "count=1" from corruption dd Jeff King
2013-06-14 21:51 ` [PATCH 0/2] recover from "failed to apply delta" Junio C Hamano
2013-06-14 21:56 ` Jeff King
2013-06-14 22:23 ` Junio C Hamano
2013-06-14 21:53 ` [PATCH 2/2] unpack_entry: do not die when we fail to apply a delta Jeff King
2013-06-14 21:59 ` Junio C Hamano
2013-06-14 22:19 ` Jeff King
2013-06-14 14:53 ` [PATCH] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.03.1306132004090.18597@syhkavp.arg \
--to=nico@fluxnic.net \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).