From: Nicolas Pitre <nico@fluxnic.net>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] find_pack_entry(): do not keep packed_git pointer locally
Date: Mon, 30 Jan 2012 23:19:54 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.02.1201302301150.2759@xanadu.home> (raw)
In-Reply-To: <CACsJy8AS0nZOoXZZfz0OEwoWe88wp2aGR5NGqpG7xQmUvwi7TA@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1534 bytes --]
On Tue, 31 Jan 2012, Nguyen Thai Ngoc Duy wrote:
> (Pulling Nico in for Q2 below. No snipping so he has a context)
>
> 2012/1/31 Junio C Hamano <gitster@pobox.com>:
> > Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> >
> >> Commit f7c22cc (always start looking up objects in the last used pack
> >> first - 2007-05-30) introduces a static packed_git* pointer as an
> >> optimization. The kept pointer however may become invalid if
> >> free_pack_by_name() happens to free that particular pack.
Hmmm, good point.
> >> Current code base does not access packs after calling
> >> free_pack_by_name() so it should not be a problem. Anyway, move the
> >> pointer out so that free_pack_by_name() can reset it to avoid running
> >> into troubles in future.
> >>
> >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> >> ---
[...]
> > - Could we make the magic (void *)1 value a #define'd constant? Perhaps
> > we could even use NULL for that purpose?
>
> Q1. Sure.
Indeed. The idea might have been to use a non null value that cannot
match any pointer...
> Q2. No NULL is probably not suitable. I think Nico wanted to express
> "we tried to find but found none (i.e. NULL)" too and 1 means "no we
> have not tried".
Well, I could imagine I might have thought about something like that.
However, looking at the latest code in the master branch I can't see
any way for last_found to ever be assigned a NULL value. So if the
(void*)1 value might have been useful, it is certainly not anymore.
Nicolas
next prev parent reply other threads:[~2012-01-31 4:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 11:25 [PATCH] find_pack_entry(): do not keep packed_git pointer locally Nguyễn Thái Ngọc Duy
2012-01-30 23:26 ` Junio C Hamano
2012-01-31 2:01 ` Nguyen Thai Ngoc Duy
2012-01-31 4:19 ` Nicolas Pitre [this message]
[not found] ` <1328010239-29669-1-git-send-email-pclouds@gmail.com>
2012-01-31 18:02 ` [PATCH v2] " Junio C Hamano
2012-01-31 19:28 ` Nicolas Pitre
2012-02-01 13:48 ` [PATCH v3 1/2] Factor find_pack_entry()'s core out Nguyễn Thái Ngọc Duy
2012-02-01 13:48 ` [PATCH v3 2/2] find_pack_entry(): do not keep packed_git pointer locally Nguyễn Thái Ngọc Duy
2012-02-01 16:02 ` Nicolas Pitre
2012-02-02 13:53 ` [PATCH v4 " Nguyễn Thái Ngọc Duy
2012-02-01 15:59 ` [PATCH v3 1/2] Factor find_pack_entry()'s core out Nicolas Pitre
2012-02-01 22:03 ` Junio C Hamano
2012-02-01 22:33 ` Junio C Hamano
2012-02-01 23:37 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1201302301150.2759@xanadu.home \
--to=nico@fluxnic.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).