From: Nicolas Pitre <nico@cam.org>
To: Nick Edelen <sirnot@gmail.com>
Cc: sam@vilain.net, git@vger.kernel.org,
"Shawn O. Pearce" <spearce@spearce.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Andreas Ericsson <exon@op5.se>,
Christian Couder <christian@couder.net>,
Jeff King <peff@peff.net>
Subject: Re: [WIP] Shift rev-list enumeration from upload-pack to pack-objects
Date: Sun, 07 Jun 2009 20:50:24 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0906072043400.3906@xanadu.home> (raw)
In-Reply-To: <c77435a80906071504u16a46e03w6dfde9a3e694a5ec@mail.gmail.com>
On Mon, 8 Jun 2009, Nick Edelen wrote:
> man I can sure be blind at times... alright fixed the latter two
> comments. I changed the test file because that particular test wanted
> upload-pack to fail through the revision walker, which it could only
> now do if shallow objects were involved.
OK. However, since now we have 2 different paths for creating object
list instead of only one (the existing one in upload-pack and the one in
pack-objects), I'd prefer if you could add another test case to make
sure the pack-objects path also fails appropriately.
The rest looks fine to me, and with the test issue fixed you could add
my:
Acked-by: Nicolas Pitre <nico@cam.org
to your next submission. Oh and you might change the subject prefix to
[PATCH] as well since I think this won't be WIP anymore.
Nicolas
next prev parent reply other threads:[~2009-06-08 0:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 5:45 [WIP] Shift rev-list enumeration from upload-pack to pack-objects sam, Nick Edelen
2009-06-05 5:46 ` Sam Vilain
2009-06-05 8:10 ` Johannes Sixt
2009-06-08 8:51 ` [PATCH] fetch-pack: close output channel after sideband demultiplexer terminates Johannes Sixt
2009-06-05 16:51 ` [WIP] Shift rev-list enumeration from upload-pack to pack-objects Nicolas Pitre
2009-06-07 13:25 ` Nick Edelen
2009-06-07 13:31 ` Nick Edelen
2009-06-07 16:41 ` Nicolas Pitre
2009-06-07 16:47 ` Nick Edelen
2009-06-07 18:55 ` Nick Edelen
2009-06-07 20:48 ` Sam Vilain
2009-06-07 20:48 ` Nicolas Pitre
2009-06-07 22:04 ` Nick Edelen
2009-06-08 0:50 ` Nicolas Pitre [this message]
2009-06-08 2:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0906072043400.3906@xanadu.home \
--to=nico@cam.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=christian@couder.net \
--cc=exon@op5.se \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sam@vilain.net \
--cc=sirnot@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).