From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Kristian H?gsberg <krh@redhat.com>
Subject: Re: performance problem: "git commit filename"
Date: Sun, 13 Jan 2008 09:24:02 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.1.00.0801130922030.2806@woody.linux-foundation.org> (raw)
In-Reply-To: <7vd4s6qal0.fsf@gitster.siamese.dyndns.org>
On Sun, 13 Jan 2008, Junio C Hamano wrote:
>
> The attached is a quick and dirty hack which may or may not
> help. It all looks sane, this also is some core code, and meant
> only for discussion and not application.
I don't think this will help.
You never set CE_UPTODATE, except in the "fill_stat_cache_info()"
function, but that one will never be called for an old file that already
matched the stat.
So at a minimum, you should also make ie_match_stat() set CE_UPTODATE if
it matches. Or something.
Linus
next prev parent reply other threads:[~2008-01-13 17:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 22:46 performance problem: "git commit filename" Linus Torvalds
2008-01-13 1:46 ` Linus Torvalds
2008-01-13 4:04 ` Linus Torvalds
2008-01-13 5:38 ` Daniel Barkalow
2008-01-13 8:14 ` Junio C Hamano
2008-01-13 16:57 ` Linus Torvalds
2008-01-13 19:31 ` Daniel Barkalow
2008-01-13 8:12 ` Junio C Hamano
2008-01-13 10:33 ` Junio C Hamano
2008-01-13 10:54 ` [PATCH] builtin-commit.c: do not lstat(2) partially committed paths twice Junio C Hamano
2008-01-13 11:09 ` performance problem: "git commit filename" Junio C Hamano
2008-01-13 17:24 ` Linus Torvalds [this message]
2008-01-13 19:39 ` Junio C Hamano
2008-01-13 22:36 ` [PATCH] index: be careful when handling long names Junio C Hamano
2008-01-13 22:53 ` Alex Riesen
2008-01-13 23:08 ` Junio C Hamano
2008-01-13 23:33 ` Alex Riesen
2008-01-14 21:03 ` Junio C Hamano
2008-01-14 1:00 ` performance problem: "git commit filename" Junio C Hamano
2008-01-14 17:07 ` Linus Torvalds
2008-01-14 18:38 ` Junio C Hamano
2008-01-14 19:39 ` Linus Torvalds
2008-01-14 20:08 ` Junio C Hamano
2008-01-14 21:00 ` Linus Torvalds
2008-01-15 0:18 ` Linus Torvalds
2008-01-15 1:13 ` Junio C Hamano
2008-01-13 10:38 ` [PATCH] builtin-commit.c: remove useless check added by faulty cut and paste Junio C Hamano
2008-01-14 21:23 ` しらいしななこ
2008-01-14 21:54 ` Junio C Hamano
2008-01-14 23:46 ` performance problem: "git commit filename" Kristian Høgsberg
2008-01-14 23:15 ` Kristian Høgsberg
2008-01-14 23:48 ` Junio C Hamano
2008-01-14 23:53 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0801130922030.2806@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).