git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Kastrup <dak@gnu.org>
Cc: Geert Bosch <bosch@adacore.com>,
	David Symonds <dsymonds@gmail.com>,
	Wincent Colaiuta <win@wincent.com>,
	Johan Herland <johan@herland.net>,
	git@vger.kernel.org, Marius Storm-Olsen <marius@trolltech.com>,
	Christian Couder <chriscool@tuxfamily.org>,
	Ren? Scharfe <rene.scharfe@lsrfire.ath.cx>,
	Junio Hamano <junkio@cox.net>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 0/7] Bisect dunno
Date: Wed, 17 Oct 2007 15:59:04 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0710171553580.26902@woody.linux-foundation.org> (raw)
In-Reply-To: <85ve98gl57.fsf@lola.goethe.zz>



On Mon, 15 Oct 2007, David Kastrup wrote:

> Geert Bosch <bosch@adacore.com> writes:
> 
> > On Oct 15, 2007, at 13:53, David Symonds wrote:
> >> That's also why I suggested "skip"; you might not be able to test a
> >> particular commit, but you might also not *want* to test a particular
> >> commit for some reason.
> >
> > Skip seems a great choice: it directly expresses the wish to
> > not consider a certain commit. The reason is unimportant.
> 
> But it is an _action_, while "good" and "bad" are properties.

Well, this has been debated to death, but I actually think that "skip" is 
a good choice, exactly because it's an action.

"good" and "bad" do indeed describe properties of the commit, and are used 
to describe the state of the tree in question. In contrast, "git bisect 
skip" says not somethign about the state of that tree - it talks about 
what we should *do* with that tree.

IOW, I think "git bisect skip" in some sense has more to do with an action 
like "git bisect start", than with "good" or "bad". 

(Yes, "good" and "bad" have an action associated with them too - namely to 
start the next bisection event - but they are not named according to the 
action they cause, but because they describe the tree state)

			Linus

  parent reply	other threads:[~2007-10-17 23:01 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-14 12:28 [PATCH 0/7] Bisect dunno Christian Couder
2007-10-14 12:43 ` Wincent Colaiuta
2007-10-14 12:59   ` Wincent Colaiuta
2007-10-14 13:00   ` David Kastrup
2007-10-14 15:09     ` Christian Couder
2007-10-14 15:09       ` David Kastrup
2007-10-14 15:14         ` Andreas Ericsson
2007-10-14 16:13       ` René Scharfe
2007-10-14 16:25         ` David Kastrup
2007-10-14 16:35           ` Wincent Colaiuta
2007-10-14 17:24             ` Marius Storm-Olsen
2007-10-14 17:48               ` David Kastrup
2007-10-15  6:04                 ` Marius Storm-Olsen
2007-10-15  6:15                   ` David Symonds
2007-10-15  7:02                     ` Johan Herland
2007-10-15  9:31                       ` Wincent Colaiuta
2007-10-15 11:53                         ` David Symonds
2007-10-15 20:33                           ` Geert Bosch
2007-10-15 20:47                             ` David Kastrup
2007-10-16  6:07                               ` David Symonds
2007-10-16  6:17                                 ` David Kastrup
2007-10-17 16:10                                   ` Robin Rosenberg
2007-10-17 16:13                                     ` David Kastrup
2007-10-17 16:17                                     ` Karl Hasselström
2007-10-17 19:23                                       ` Karl Hasselström
2007-10-17 22:59                               ` Linus Torvalds [this message]
2007-10-17 23:46                                 ` Johannes Schindelin
2007-10-17 23:59                                   ` Linus Torvalds
2007-10-18  1:24                                   ` David Symonds
     [not found]                                 ` <200710190449.49477.chriscool@tuxfamily.org>
2007-10-19  2:49                                   ` Shawn O. Pearce
2007-10-16  3:41                     ` Christian Couder
2007-10-15  8:25                   ` David Kastrup
2007-10-14 17:25       ` Johannes Schindelin
2007-10-14 16:16 ` Johannes Schindelin
2007-10-17  7:35 ` Shawn O. Pearce
2007-10-17 18:10   ` Johannes Schindelin
2007-10-17 23:36     ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0710171553580.26902@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=bosch@adacore.com \
    --cc=chriscool@tuxfamily.org \
    --cc=dak@gnu.org \
    --cc=dsymonds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johan@herland.net \
    --cc=junkio@cox.net \
    --cc=marius@trolltech.com \
    --cc=rene.scharfe@lsrfire.ath.cx \
    --cc=win@wincent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).