From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] diffcore-rename: cache file deltas
Date: Tue, 2 Oct 2007 18:36:50 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.999.0710021832520.3579@woody.linux-foundation.org> (raw)
In-Reply-To: <7vy7eu4eos.fsf@gitster.siamese.dyndns.org>
On Tue, 25 Sep 2007, Junio C Hamano wrote:
> >
> > - the name diff_free_filespec_data_large is horrible, but this is based
> > on the fact that diff_free_filespec_data actually does too much (it
> > frees the data _and_ some other auxiliary data). And renaming that
> > would entail changing many callsites.
>
> True. But we can rename it to diff_file_filespec_blob() and
> that would perfectly well describe what it does. Will do so
> when applying if it is Ok to you.
Well, that renaming apparently never happened, and it's still called
diff_free_filespec_data_large() now that it's in master.
That said, I think this patch should make it into the maintenance branch
too, renamed or not, since it's such a huge performance issue.
Linus
next prev parent reply other threads:[~2007-10-03 1:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 19:29 [PATCH] diffcore-rename: cache file deltas Jeff King
2007-09-25 21:29 ` Junio C Hamano
2007-09-25 21:42 ` Jeff King
2007-10-03 1:36 ` Linus Torvalds [this message]
2007-10-03 4:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0710021832520.3579@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).